From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#68401: 30.0.50; ERC 5.6-git: `erc-cmd-GMSG', `erc-cmd-AMSG', `erc-cmd-GME', `erc-cmd-AME'. 2nd attempt Date: Tue, 23 Jan 2024 16:34:17 -0800 Message-ID: <87il3jh8mu.fsf__35629.5012797759$1706056526$gmane$org@neverwas.me> References: <87v87yvnly.fsf@dataswamp.org> <834jfikb4d.fsf@gnu.org> <87mstavias.fsf@dataswamp.org> <87wmseoskl.fsf@dataswamp.org> <87plxyowpg.fsf__13716.8874776521$1705633220$gmane$org@neverwas.me> <87il3ki2tg.fsf@dataswamp.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21350"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 68401@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 24 01:35:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rSREc-0005MO-3w for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jan 2024 01:35:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSREK-0005TU-F1; Tue, 23 Jan 2024 19:35:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSREI-0005SN-6W for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 19:34:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSREH-00040d-Sp for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 19:34:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rSREM-00007A-A3 for bug-gnu-emacs@gnu.org; Tue, 23 Jan 2024 19:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jan 2024 00:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68401 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68401-submit@debbugs.gnu.org id=B68401.1706056470392 (code B ref 68401); Wed, 24 Jan 2024 00:35:02 +0000 Original-Received: (at 68401) by debbugs.gnu.org; 24 Jan 2024 00:34:30 +0000 Original-Received: from localhost ([127.0.0.1]:44182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSRDq-00006G-0a for submit@debbugs.gnu.org; Tue, 23 Jan 2024 19:34:30 -0500 Original-Received: from mail-108-mta201.mxroute.com ([136.175.108.201]:43955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rSRDm-000065-PN for 68401@debbugs.gnu.org; Tue, 23 Jan 2024 19:34:27 -0500 Original-Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta201.mxroute.com (ZoneMTA) with ESMTPSA id 18d38e3a7510003727.001 for <68401@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 24 Jan 2024 00:34:20 +0000 X-Zone-Loop: 8253a50d68d7acbf92abbb522297f538c9ed531793ac X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jiQUL7Q1IjHK2w5Hwx9vapJZE+WyEfEYDuZLep7xt8U=; b=HJ0IPdspN6S3nu0bEpswhVQoB3 E3zDc2fAp7z9m5dv3b5Kn5Dsv9WzOLQTR+EMtLyxDtTodm0BKbM4n9oj01vpDQTj5VUbuyC8fkBUw t14yVU7D1isMQpGWKbwdjDAkEF+fEg/HwedvPrPUOGv7WyHqsCqb+C00WzHG575LfIJP71zUP4IFT uzPV8K/89WQQ/KsH/Ta2FZH1M7Obkc3KKcpXZCJfeGMjvrhj053+lRZfVJDlVbdqhoV+s74Oe9W0d PuMi8Fd1fWWc+qPRmikqmshk8451KpUSrFM0BabPHCK+Et+mxHMrhmgI2oHe8FLnSsM9NNPWLPsSp uhIUj8IQ==; In-Reply-To: <87il3ki2tg.fsf@dataswamp.org> (Emanuel Berg's message of "Tue, 23 Jan 2024 14:42:19 +0100") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278752 Archived-At: Emanuel Berg writes: > J.P. wrote: > >> The attached patch is a unit test for all four commands. >> It doesn't bother asserting M-x behavior (because see >> above). Please try to make it pass without changing the test >> itself (unless there's a bug). >> >> $ git am /tmp/0002-5.x-Add...etc.patch >> >> $ make -C test lisp/erc/erc-scenarios-misc-commands.log \ >> SELECTOR=erc-scenarios-misc-commands--AMSG-GMSG-AME-GME > > The test failed > > (error "Failed awaiting: string: bob: Our queen and all") > > Here is the entire erc-scenarios-misc-commands.log > > Source file `/home/incal/src/emacs/lisp/emacs-lisp/bytecomp.el' newer than byte-compiled file; using older file ^~~~~~ hint $ ./src/emacs -Q -batch -l erc -eval "(print (list :minep? (fboundp 'erc-cmd-GMSG)))" > Source file `/home/incal/src/emacs/lisp/erc/erc.el' newer than byte-compiled file; using older file > Source file `/home/incal/src/emacs/lisp/erc/erc-common.el' newer than byte-compiled file; using older file > Source file `/home/incal/src/emacs/lisp/auth-source.el' newer than byte-compiled file; using older file > Running 1 tests (2024-01-23 14:35:36+0100, selector `erc-scenarios-misc-commands--AMSG-GMSG-AME-GME') > Source file `/home/incal/src/emacs/lisp/erc/erc-button.el' newer than byte-compiled file; using older file > Source file `/home/incal/src/emacs/lisp/erc/erc-track.el' newer than byte-compiled file; using older file > Error running timer `erc-d--on-request': (error "Match failed: \"PRIVMSG #bar :1 foonet only\" (:exes (\"\\\\`PRIVMSG #bar :2 barnet only\") :dialog amsg-barnet)") > Test erc-scenarios-misc-commands--AMSG-GMSG-AME-GME backtrace: > Source file `/home/incal/src/emacs/lisp/help-fns.el' newer than byte-compiled file; using older file > error("Failed awaiting: %s" "string: bob: Our queen and all" > (if inverted (setq inverted nil) (error "Failed awaiting: %s" (forma > (progn (if inverted (setq inverted nil) (error "Failed awaiting: %s" > (if (eq -with-timeout-value- 'timeout) (progn (if inverted (setq inv > (let ((-with-timeout-value- (catch 'timeout (let* ((-with-timeout-ti > (let ((time-out (abs timeout)) (inverted (< timeout 0)) (result 'res > (let ((ert--infos (cons (cons "Info: " (concat erc-d-t--wait-message > (let* ((rxp (consp text)) (fun (if rxp #'search-forward-regexp #'sea > (save-restriction (widen) (let* ((rxp (consp text)) (fun (if rxp #'s > erc-d-t-search-for(10 " bob: Our queen and all" # (let* ((pos (cdr (assq (current-buffer) positions))) (erc-d-t--wait- > (closure ((positions (# . #) (#< > funcall((closure ((positions (# . # (save-current-buffer (set-buffer "#foo") (funcall expect 10 " (let ((ert--infos (cons (cons "Info: " "/AMSG only sent to issuing c > (progn (erc-scenarios-common--add-silence) (let ((ert--infos (cons ( > (unwind-protect (progn (erc-scenarios-common--add-silence) (let ((er > (let* ((orig-autojoin-mode (and (boundp 'erc-autojoin-mode) erc-auto > (closure (t) nil (let* ((orig-autojoin-mode (and (boundp 'erc-autojo > #f(compiled-function () #)() > handler-bind-1(#f(compiled-function () # ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test > ert-run-test(#s(ert-test :name erc-scenarios-misc-commands--AMSG-GMS > ert-run-or-rerun-test(#s(ert--stats :selector erc-scenarios-misc-com > ert-run-tests(erc-scenarios-misc-commands--AMSG-GMSG-AME-GME #f(comp > ert-run-tests-batch(erc-scenarios-misc-commands--AMSG-GMSG-AME-GME) > ert-run-tests-batch-and-exit(erc-scenarios-misc-commands--AMSG-GMSG- > eval((ert-run-tests-batch-and-exit 'erc-scenarios-misc-commands--AMS > command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/erc/erc-scenarios-mi > command-line() > normal-top-level() > Test erc-scenarios-misc-commands--AMSG-GMSG-AME-GME condition: > Info: /AMSG only sent to issuing context's server > Info: string: bob: Our queen and all > (error "Failed awaiting: string: bob: Our queen and all") > Source file `/home/incal/src/emacs/lisp/vc/vc-git.el' newer than byte-compiled file; using older file > FAILED 1/1 erc-scenarios-misc-commands--AMSG-GMSG-AME-GME (10.450133 sec) at lisp/erc/erc-scenarios-misc-commands.el:133 > > Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-23 14:35:47+0100, 10.618589 sec) > > 1 unexpected results: > FAILED erc-scenarios-misc-commands--AMSG-GMSG-AME-GME