From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org
Cc: eliz@gnu.org
Subject: Re: bug#9782: 24.0.90; move-to-window-line not taking header line into account
Date: Sun, 05 May 2013 01:12:52 +0400 [thread overview]
Message-ID: <87haiiqwiz.fsf@yandex.ru> (raw)
In-Reply-To: <83mxcyuw60.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 18 Oct 2011 18:00:39 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: David Engster <deng@randomsample.de>
>> Cc: 9782@debbugs.gnu.org
>> Date: Tue, 18 Oct 2011 16:23:37 +0200
>>
>> My report was motivated by seeing that the tooltip display of
>> company-mode (currently in ELPA) broke due to the change in
>> posn-actual-col-row. Company-mode happens to depend on the above test
>> case, that means it first determines the actual row at point, moves to
>> (1+ row) through move-to-window-line and then displays the overlay
>> there. I don't know why it chooses this way to do this, but it has
>> worked for years, so I figured move-to-window-line has to be fixed. If
>> this new behavior is the correct one, then please close this report and
>> I will send a bug report to the author of company-mode.
>
> I'm closing the bug report. My opinion is that company-mode should
> either change the way it computes the line to move to, or account for
> the header-line itself (e.g., by looking at the value of
> header-line-format). If the author of that package disagrees, I
> suggest that he or she starts a discussion on emacs-devel.
There you go, I'm starting the discussion.
What do you suggest would be a better way to get the window row of a
buffer position, save that value, and then move to that row later?
Currently, company calls (cdr (posn-actual-col-row posn)) to retrieve
the row, and `move-to-window-line' to get to it.
Simply adjusting the row number for presence of `header-line-format'
won't do, because company strives to support Emacs 23 (and maybe even
22), and `post-actual-col-row' behavior was different before the
revision 106022.
--Dmitry
next prev parent reply other threads:[~2013-05-04 21:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 12:03 bug#9782: 24.0.90; move-to-window-line not taking header line into account David Engster
2011-10-18 14:00 ` Eli Zaretskii
2011-10-18 14:23 ` David Engster
2011-10-18 16:00 ` Eli Zaretskii
2013-05-04 21:12 ` Dmitry Gutov [this message]
2013-05-05 2:47 ` Eli Zaretskii
2013-05-05 2:59 ` Dmitry Gutov
2013-05-05 15:53 ` Eli Zaretskii
2013-05-06 3:38 ` Dmitry Gutov
2013-05-06 16:38 ` Eli Zaretskii
2013-05-07 1:26 ` Dmitry Gutov
2013-05-07 2:54 ` Eli Zaretskii
2013-05-07 7:41 ` Dmitry Gutov
2013-05-07 16:50 ` Eli Zaretskii
2013-05-07 17:19 ` Dmitry Gutov
2014-08-15 23:33 ` Dmitry Gutov
2014-08-16 8:03 ` Eli Zaretskii
2014-08-16 8:27 ` Dmitry Gutov
2014-08-16 11:12 ` Eli Zaretskii
2014-08-19 4:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haiiqwiz.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.