From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: bug#9782: 24.0.90; move-to-window-line not taking header line into account
Date: Tue, 07 May 2013 19:50:51 +0300 [thread overview]
Message-ID: <83ip2uentg.fsf@gnu.org> (raw)
In-Reply-To: <5188B00C.2080600@yandex.ru>
> Date: Tue, 07 May 2013 11:41:00 +0400
> From: Dmitry Gutov <dgutov@yandex.ru>
> CC: emacs-devel@gnu.org
>
> On 07.05.2013 6:54, Eli Zaretskii wrote:
> >> One might think that `move-to-window-line' is also window-relative and
> >> thus agnostic to the header line (that naturally follows if we consider
> >> the header line a part of the window).
> >
> > "Line" is a line of text, and move-to-window-line was written to go to
> > a line of text.
>
> The question is how they're numbered. One might imagine that the
> "zeroth" line is covered by the header, so the first one visible is
> number one.
But you cannot move point to the header line. And argument of zero to
move-to-window-line already has a different meaning.
> >> We still need to compare the column values to see if the click happened
> >> exactly inside the rectangle, not to the right or left of it.
> >
> > Doesn't the overlay cover the entire rectangle?
> >
> >> And in `company-select-mouse', we need the row values to find out which
> >> rectangle line was clicked (which candidate to select)
> >
> > Isn't each rectangle a different string?
> >
>
> There's just one overlay, and it covers all of them (plus all text on
> the sides).
Sorry, I don't understand. Perhaps we are talking about two different
things. Are you talking about the menu-like display of possible
completions, shown to the user to let her select one of the
candidates? If so, how can they be a single overlay string, when they
are shown in different screen lines? Are you also copying the buffer
text into the overlay string or something? Otherwise I don't
understand how can you show a multi-line overlay string and still have
buffer text be seen. What am I missing?
> Maybe what you're suggesting would be an improvement (I see
> dropdown-list.el also does that), but the current approach works fast
> enough, and it would have the advantage in a hypothetical situation when
> some of the text we need to "draw on" is already rendered via `display'
> property.
I don't see any advantages even in that situation, but maybe I'm
misunderstanding what you mean.
My suggestion is to make each completion candidate a separate display
string, then the event position list will tell you directly which
string was clicked.
> I mean fixing the row number <-> line number discrepancy from the other
> side, by making a wrapper for `move-to-window-line', the only function
> of the bunch that deals with line numbers. It's used in
> `company-pseudo-tooltip-show'.
count-screen-lines also deals with line numbers.
Anyway, I think you now have the information needed to fix company.el,
and can select the implementation that you like best.
next prev parent reply other threads:[~2013-05-07 16:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 12:03 bug#9782: 24.0.90; move-to-window-line not taking header line into account David Engster
2011-10-18 14:00 ` Eli Zaretskii
2011-10-18 14:23 ` David Engster
2011-10-18 16:00 ` Eli Zaretskii
2013-05-04 21:12 ` Dmitry Gutov
2013-05-05 2:47 ` Eli Zaretskii
2013-05-05 2:59 ` Dmitry Gutov
2013-05-05 15:53 ` Eli Zaretskii
2013-05-06 3:38 ` Dmitry Gutov
2013-05-06 16:38 ` Eli Zaretskii
2013-05-07 1:26 ` Dmitry Gutov
2013-05-07 2:54 ` Eli Zaretskii
2013-05-07 7:41 ` Dmitry Gutov
2013-05-07 16:50 ` Eli Zaretskii [this message]
2013-05-07 17:19 ` Dmitry Gutov
2014-08-15 23:33 ` Dmitry Gutov
2014-08-16 8:03 ` Eli Zaretskii
2014-08-16 8:27 ` Dmitry Gutov
2014-08-16 11:12 ` Eli Zaretskii
2014-08-19 4:51 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ip2uentg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.