From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: bug#9782: 24.0.90; move-to-window-line not taking header line into account Date: Sun, 05 May 2013 01:12:52 +0400 Message-ID: <87haiiqwiz.fsf@yandex.ru> References: <83mxcyuw60.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1367701999 8820 80.91.229.3 (4 May 2013 21:13:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 May 2013 21:13:19 +0000 (UTC) Cc: eliz@gnu.org To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat May 04 23:13:17 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UYjld-00084n-He for ged-emacs-devel@m.gmane.org; Sat, 04 May 2013 23:13:17 +0200 Original-Received: from localhost ([::1]:51624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYjlc-0000QG-U6 for ged-emacs-devel@m.gmane.org; Sat, 04 May 2013 17:13:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYjlW-0000OS-VJ for emacs-devel@gnu.org; Sat, 04 May 2013 17:13:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYjlS-0002tc-VZ for emacs-devel@gnu.org; Sat, 04 May 2013 17:13:10 -0400 Original-Received: from mail-lb0-f180.google.com ([209.85.217.180]:55799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYjlM-0002qz-36; Sat, 04 May 2013 17:13:00 -0400 Original-Received: by mail-lb0-f180.google.com with SMTP id v1so2456376lbd.11 for ; Sat, 04 May 2013 14:12:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type:x-antivirus :x-antivirus-status; bh=FiZlzPMpHSKEovhHrU1wdBoZzdIH5DDK50l/Lo0vOWI=; b=cNyzeOOeEoNw+a1tUTUuWHAha5kreXNdQq3N9Ny0IUSyQE01aTRXBDtsGzZAvmevFq 6HAz5BrVnXiWuU/pdwgCZeylUrQY9rhPHBq0jCPEsdcYY+n/eDgscp31N4bT545sndNb 3tbLEH8LrMKL0HoZ1lsx3zYklnQHsBleVyJufLI2y+xKJgUYuNVx/NzAgvBA5h2rkU4B Yt8QYJOgGmKSFxSKB2hteK7M1OdnaVLxQxRFLPW98vQfZUPa9MgeqBhFhScnqUED4irw BZ1TlzL7TTFbuuQFCES46mGjI1+rzacR7KNKkqHijdQokvawWEPex7a61HFNKrScWT6L hEUg== X-Received: by 10.112.144.36 with SMTP id sj4mr6076410lbb.1.1367701979000; Sat, 04 May 2013 14:12:59 -0700 (PDT) Original-Received: from SOL ([178.252.98.87]) by mx.google.com with ESMTPSA id h2sm6417968lah.4.2013.05.04.14.12.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 04 May 2013 14:12:58 -0700 (PDT) In-Reply-To: <83mxcyuw60.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 18 Oct 2011 18:00:39 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) X-Antivirus: avast! (VPS 130504-0, 04.05.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.217.180 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159299 Archived-At: Eli Zaretskii writes: >> From: David Engster >> Cc: 9782@debbugs.gnu.org >> Date: Tue, 18 Oct 2011 16:23:37 +0200 >> >> My report was motivated by seeing that the tooltip display of >> company-mode (currently in ELPA) broke due to the change in >> posn-actual-col-row. Company-mode happens to depend on the above test >> case, that means it first determines the actual row at point, moves to >> (1+ row) through move-to-window-line and then displays the overlay >> there. I don't know why it chooses this way to do this, but it has >> worked for years, so I figured move-to-window-line has to be fixed. If >> this new behavior is the correct one, then please close this report and >> I will send a bug report to the author of company-mode. > > I'm closing the bug report. My opinion is that company-mode should > either change the way it computes the line to move to, or account for > the header-line itself (e.g., by looking at the value of > header-line-format). If the author of that package disagrees, I > suggest that he or she starts a discussion on emacs-devel. There you go, I'm starting the discussion. What do you suggest would be a better way to get the window row of a buffer position, save that value, and then move to that row later? Currently, company calls (cdr (posn-actual-col-row posn)) to retrieve the row, and `move-to-window-line' to get to it. Simply adjusting the row number for presence of `header-line-format' won't do, because company strives to support Emacs 23 (and maybe even 22), and `post-actual-col-row' behavior was different before the revision 106022. --Dmitry