From: Philip Kaludercic <philipk@posteo.net>
To: Robert Pluim <rpluim@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, Eli Zaretskii <eliz@gnu.org>,
55039@debbugs.gnu.org
Subject: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries
Date: Tue, 06 Sep 2022 15:02:53 +0000 [thread overview]
Message-ID: <87h71kfsv6.fsf@posteo.net> (raw)
In-Reply-To: <877d2gczy8.fsf@gmail.com> (Robert Pluim's message of "Tue, 06 Sep 2022 16:58:07 +0200")
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Tue, 06 Sep 2022 14:34:58 +0000, Philip Kaludercic <philipk@posteo.net> said:
> Philip> (defun diff-add-log-current-defuns ()
> Philip> "Return an alist of defun names for the current diff.
> Philip> The elements of the alist are of the form (FILE . (DEFUN...)),
> Philip> @@ -2374,9 +2380,11 @@ diff-add-log-current-defuns
> Philip> (re-search-forward diff-hunk-header-re nil t)
> Philip> (setq hunk-end (save-excursion (diff-end-of-hunk)))
> Philip> (pcase-let* ((filename (substring-no-properties
> Philip> - (file-relative-name
> Philip> - (diff-find-file-name)
> Philip> - (vc-root-dir))))
> Philip> + (if diff-relative-names-in-changelog
> Philip> + (file-relative-name
> Philip> + (diff-find-file-name)
> Philip> + (vc-root-dir))
> Philip> + (diff-find-file-name))))
> Philip> (=lines 0)
> Philip> (+lines 0)
> Philip> (-lines 0)
>
> That doesnʼt look like the code thatʼs currently in master. Is this on
> top of your previous patch?
No, these changes would be on top of the previous patch, but I'm of
course going to merge them into a single commit.
> Philip> Assuming nobody objects to the name of the option, should this be
> Philip> documented in NEWS and/or in the Manual? Also, as the entire point of
> Philip> the patch was that emacs.git is using relative path names, should a
> Philip> .dir-locals.el variable be set to ensure this is done?
>
> NEWS and .dir-locals.el definitely. I guess you could add to the "Log
> Buffer" node in the emacs manual if youʼre feeling inspired 😀
I'll consider it.
> Robert
next prev parent reply other threads:[~2022-09-06 15:02 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:19 bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries Philip Kaludercic
2022-04-20 16:01 ` Eli Zaretskii
2022-09-06 11:13 ` Lars Ingebrigtsen
2022-09-06 11:24 ` Eli Zaretskii
2022-09-06 11:30 ` Lars Ingebrigtsen
2022-09-06 12:45 ` Philip Kaludercic
2022-09-06 14:34 ` Philip Kaludercic
2022-09-06 14:39 ` Lars Ingebrigtsen
2022-09-06 14:58 ` Robert Pluim
2022-09-06 15:02 ` Philip Kaludercic [this message]
2022-09-06 15:46 ` Eli Zaretskii
2022-09-06 20:11 ` Philip Kaludercic
2022-09-08 7:07 ` Eli Zaretskii
2022-09-08 8:45 ` Philip Kaludercic
2022-09-08 9:20 ` Eli Zaretskii
2022-09-08 12:11 ` Lars Ingebrigtsen
2022-09-08 12:19 ` Visuwesh
2022-09-08 12:33 ` Lars Ingebrigtsen
2022-09-08 12:43 ` Philip Kaludercic
2022-09-08 12:44 ` Lars Ingebrigtsen
2022-09-08 12:53 ` Philip Kaludercic
2022-09-08 12:56 ` Lars Ingebrigtsen
2022-09-11 8:16 ` Philip Kaludercic
2022-09-11 11:08 ` Lars Ingebrigtsen
2022-09-08 12:56 ` Robert Pluim
2022-09-08 13:10 ` Lars Ingebrigtsen
2022-09-08 13:13 ` Visuwesh
2022-09-08 12:52 ` Robert Pluim
2022-09-06 16:13 ` Juri Linkov
2022-09-06 20:10 ` Philip Kaludercic
2022-09-07 10:08 ` Robert Pluim
2022-09-07 12:48 ` Lars Ingebrigtsen
2022-09-07 13:27 ` Eli Zaretskii
2022-09-07 15:53 ` Philip Kaludercic
2022-09-07 18:12 ` Eli Zaretskii
2022-09-07 18:27 ` Philip Kaludercic
2022-09-07 18:46 ` Eli Zaretskii
2022-09-07 21:23 ` Philip Kaludercic
2022-09-08 5:38 ` Eli Zaretskii
2022-09-08 6:22 ` Philip Kaludercic
2022-09-08 2:58 ` Richard Stallman
2022-09-08 6:18 ` Philip Kaludercic
2022-04-22 3:03 ` Richard Stallman
2022-04-22 5:29 ` Eli Zaretskii
2022-04-23 3:46 ` Richard Stallman
2022-04-23 6:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h71kfsv6.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=55039@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=larsi@gnus.org \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.