From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries Date: Tue, 06 Sep 2022 15:02:53 +0000 Message-ID: <87h71kfsv6.fsf@posteo.net> References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <877d2gczy8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3062"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Eli Zaretskii , 55039@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 06 17:04:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVa7a-0000ZA-NL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 17:04:14 +0200 Original-Received: from localhost ([::1]:59700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVa7Z-0002K2-Hv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 11:04:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVa7O-0002Hy-86 for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 11:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35390) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVa7N-0001UY-Vs for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 11:04:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVa7N-0003md-Oq for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 11:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2022 15:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 55039-submit@debbugs.gnu.org id=B55039.166247658414465 (code B ref 55039); Tue, 06 Sep 2022 15:04:01 +0000 Original-Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 15:03:04 +0000 Original-Received: from localhost ([127.0.0.1]:52322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVa6R-0003lE-Hk for submit@debbugs.gnu.org; Tue, 06 Sep 2022 11:03:03 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:43013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVa6Q-0003kK-1m for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 11:03:02 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0DDFF240026 for <55039@debbugs.gnu.org>; Tue, 6 Sep 2022 17:02:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662476576; bh=N4DELu3OmUniesjvGLtGgnkw+k6Gjeo2Xg3U2H3810M=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=JmnidIU1f+vYEtLV1ppC0n/5XNXcPQtn0TNAiMUAaOEd7UCrWK/LBW2ngaZDRgXf4 JNT9sx2JUXr+OT4r3d2S4jYuWmhrfb9isxa4G18KfD9txM7w+34NLgizkweZT1Egya 2ikuc7/jLrIIK7s1CGvrkFZW5jZvUCviyWRagrLuuU03NQmjJnje7fMyF9R2ZAq1c4 zrIY+zc5gu8Mx8s7/MpdVio/G1dPjRINrAFOCfTt26fAkvvjCuyR/xrRuD2pHb9E9/ M4wFtGc5MLrfan1Sv/exbNA583mUTXE9AoOMAF+OzlePi7btojE0su6ErnHpRP6w/d jWbx389xQZFuA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MMTCL0xFyz6tpp; Tue, 6 Sep 2022 17:02:53 +0200 (CEST) In-Reply-To: <877d2gczy8.fsf@gmail.com> (Robert Pluim's message of "Tue, 06 Sep 2022 16:58:07 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241681 Archived-At: Robert Pluim writes: >>>>>> On Tue, 06 Sep 2022 14:34:58 +0000, Philip Kaludercic said: > Philip> (defun diff-add-log-current-defuns () > Philip> "Return an alist of defun names for the current diff. > Philip> The elements of the alist are of the form (FILE . (DEFUN...)= ), > Philip> @@ -2374,9 +2380,11 @@ diff-add-log-current-defuns > Philip> (re-search-forward diff-hunk-header-re nil t) > Philip> (setq hunk-end (save-excursion (diff-end-of-hunk))) > Philip> (pcase-let* ((filename (substring-no-properties > Philip> - (file-relative-name > Philip> - (diff-find-file-name) > Philip> - (vc-root-dir)))) > Philip> + (if diff-relative-names-in-c= hangelog > Philip> + (file-relative-name > Philip> + (diff-find-file-name) > Philip> + (vc-root-dir)) > Philip> + (diff-find-file-name)))) > Philip> (=3Dlines 0) > Philip> (+lines 0) > Philip> (-lines 0) > > That doesn=CA=BCt look like the code that=CA=BCs currently in master. Is = this on > top of your previous patch? No, these changes would be on top of the previous patch, but I'm of course going to merge them into a single commit. > Philip> Assuming nobody objects to the name of the option, should thi= s be > Philip> documented in NEWS and/or in the Manual? Also, as the entire= point of > Philip> the patch was that emacs.git is using relative path names, sh= ould a > Philip> .dir-locals.el variable be set to ensure this is done? > > NEWS and .dir-locals.el definitely. I guess you could add to the "Log > Buffer" node in the emacs manual if you=CA=BCre feeling inspired =F0=9F= =98=80 I'll consider it. > Robert