From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: larsi@gnus.org, 55039@debbugs.gnu.org
Subject: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries
Date: Wed, 07 Sep 2022 16:27:17 +0300 [thread overview]
Message-ID: <83wnafgvre.fsf@gnu.org> (raw)
In-Reply-To: <87fsh4e01q.fsf@posteo.net> (message from Philip Kaludercic on Tue, 06 Sep 2022 20:10:41 +0000)
> From: Philip Kaludercic <philipk@posteo.net>
> Cc: Eli Zaretskii <eliz@gnu.org>, 55039@debbugs.gnu.org
> Date: Tue, 06 Sep 2022 20:10:41 +0000
>
> --- a/doc/emacs/maintaining.texi
> +++ b/doc/emacs/maintaining.texi
> @@ -694,7 +694,10 @@ Log Buffer
> (@code{log-edit-generate-changelog-from-diff}), to generate skeleton
> ChangeLog entries, listing all changed file and function names based
> on the diff of the VC fileset. Consecutive entries left empty will be
> -combined by @kbd{C-q} (@code{fill-paragraph}).
> +combined by @kbd{C-q} (@code{fill-paragraph}). By default the
> +inserted file names will just be the files without a path. If
> +@code{diff-add-log-relative-names} is non-nil, a partial path relative
> +to the VC root directory will be inserted instead.
GNU Coding Standards frown on using "path" for anything but PATH-style
directory lists. Please use "leading directories" or somesuch here,
as that's what you mean.
> +*** New user option 'diff-relative-names-in-changelog'.
> +If non-nil insert file names in ChangeLog skeletons relative to the
^
Comma missing there.
> +(defcustom diff-add-log-relative-names nil
> + "Use relative file names when generating ChangeLog messages."
This doesn't say relative to what. It also doesn't mention the
commands which are affected.
> (defun diff-add-log-current-defuns ()
> "Return an alist of defun names for the current diff.
> The elements of the alist are of the form (FILE . (DEFUN...)),
> -where DEFUN... is a list of function names found in FILE."
> +where DEFUN... is a list of function names found in FILE. If
> +`diff-add-log-relative-names' is non-nil, insert file names
> +relative to the VC root directory."
The "insert" part is out of place here, since there's no insertion.
How about
If `diff-add-log-relative-names' is non-nil, file names in the alist
are relative to the root directory of the VC repository.
instead?
next prev parent reply other threads:[~2022-09-07 13:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 14:19 bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries Philip Kaludercic
2022-04-20 16:01 ` Eli Zaretskii
2022-09-06 11:13 ` Lars Ingebrigtsen
2022-09-06 11:24 ` Eli Zaretskii
2022-09-06 11:30 ` Lars Ingebrigtsen
2022-09-06 12:45 ` Philip Kaludercic
2022-09-06 14:34 ` Philip Kaludercic
2022-09-06 14:39 ` Lars Ingebrigtsen
2022-09-06 14:58 ` Robert Pluim
2022-09-06 15:02 ` Philip Kaludercic
2022-09-06 15:46 ` Eli Zaretskii
2022-09-06 20:11 ` Philip Kaludercic
2022-09-08 7:07 ` Eli Zaretskii
2022-09-08 8:45 ` Philip Kaludercic
2022-09-08 9:20 ` Eli Zaretskii
2022-09-08 12:11 ` Lars Ingebrigtsen
2022-09-08 12:19 ` Visuwesh
2022-09-08 12:33 ` Lars Ingebrigtsen
2022-09-08 12:43 ` Philip Kaludercic
2022-09-08 12:44 ` Lars Ingebrigtsen
2022-09-08 12:53 ` Philip Kaludercic
2022-09-08 12:56 ` Lars Ingebrigtsen
2022-09-11 8:16 ` Philip Kaludercic
2022-09-11 11:08 ` Lars Ingebrigtsen
2022-09-08 12:56 ` Robert Pluim
2022-09-08 13:10 ` Lars Ingebrigtsen
2022-09-08 13:13 ` Visuwesh
2022-09-08 12:52 ` Robert Pluim
2022-09-06 16:13 ` Juri Linkov
2022-09-06 20:10 ` Philip Kaludercic
2022-09-07 10:08 ` Robert Pluim
2022-09-07 12:48 ` Lars Ingebrigtsen
2022-09-07 13:27 ` Eli Zaretskii [this message]
2022-09-07 15:53 ` Philip Kaludercic
2022-09-07 18:12 ` Eli Zaretskii
2022-09-07 18:27 ` Philip Kaludercic
2022-09-07 18:46 ` Eli Zaretskii
2022-09-07 21:23 ` Philip Kaludercic
2022-09-08 5:38 ` Eli Zaretskii
2022-09-08 6:22 ` Philip Kaludercic
2022-09-08 2:58 ` Richard Stallman
2022-09-08 6:18 ` Philip Kaludercic
2022-04-22 3:03 ` Richard Stallman
2022-04-22 5:29 ` Eli Zaretskii
2022-04-23 3:46 ` Richard Stallman
2022-04-23 6:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wnafgvre.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=55039@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.