all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Robert Pluim <rpluim@gmail.com>, John <jpff@codemist.co.uk>
Cc: 61155@debbugs.gnu.org
Subject: bug#61155: 29.0.60; build failures tree sitter
Date: Mon, 30 Jan 2023 12:40:40 +0100	[thread overview]
Message-ID: <87cz6w1c93.fsf@thornhill.no> (raw)
In-Reply-To: <877cx4z7lz.fsf@gmail.com>

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Sun, 29 Jan 2023 21:00:07 +0000, John <jpff@codemist.co.uk> said:
>
>     John> For the last couple of days I have been unable to build emacs-29
>     John> branch; error messages  are
>
>     John> In toplevel form:
>     John> cedet/semantic/wisent/python.el:30:2: Error: Symbol’s function definition is void: treesit-parser-list
>     John> make[3]: *** [Makefile:332: cedet/semantic/wisent/python.elc] Error 1"
>     John> make[3]: Leaving directory '/home/jpff/GNU/emacs/lisp'
>     John> make[2]: *** [Makefile:366: compile-main] Error 2
>     John> make[2]: Leaving directory '/home/jpff/GNU/emacs/lisp'
>     John> make[1]: *** [Makefile:533: lisp] Error 2
>     John> make[1]: Leaving directory '/home/jpff/GNU/emacs'
>     John> make[1]: Entering directory '/home/jpff/GNU/emacs'
>     John> ***
>     John> *** "make all" failed with exit status 2.
>     John> ***
>     John> *** You could try to:
>     John> *** - run "make bootstrap", which might fix the problem
>     John> *** - run "make V=1", which displays the full commands invoked by make,
>     John> ***   to further investigate the problem
>     John> ***
>     John> make[1]: *** [Makefile:414: advice-on-failure] Error 2
>     John> make[1]: Leaving directory '/home/jpff/GNU/emacs'
>
>     John> I do not have any tree-sitter code.  "make bootstrap" appears to work
>     John> but every day it takes too much time.  I read tat tree-sitter as not
>     John> necessary but this seems to contradict
>
> I suspect the following commit, which uses treesit-parser-list
> unconditionally
>
>     Bob> diff --git a/lisp/shell.el b/lisp/shell.el
>     Bob> index 5cf108bfa3b..877c48097a8 100644
>     Bob> --- a/lisp/shell.el
>     Bob> +++ b/lisp/shell.el
>     Bob> @@ -366,6 +366,11 @@ shell-has-auto-cd
>     Bob>    :group 'shell-directories
>     Bob>    :version "28.1")
>  
> commit 1de6ebf2878485a0ef6b778df7d6a14d5b22a01c
> Author: Theodor Thornhill <theo@thornhill.no>
> Date:   Sat Jan 28 13:57:01 2023 +0100
>
>     Make treesit-font-lock-level a defcustom
>
> Robert
> -- 


Can you try this and see if the error goes away?

thanks,
Theo

diff --git a/lisp/treesit.el b/lisp/treesit.el
index 92833fb007..d7e702bfb8 100644
--- a/lisp/treesit.el
+++ b/lisp/treesit.el
@@ -568,7 +568,7 @@ treesit--font-lock-level-setter
               res)
       (let ((buffer (car buffers)))
         (with-current-buffer buffer
-          (if (treesit-parser-list)
+          (if (and (treesit-available-p) (treesit-parser-list))
               (loop (append res (list buffer)) (cdr buffers))
             (loop res (cdr buffers))))))))
 





  parent reply	other threads:[~2023-01-30 11:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 21:00 bug#61155: 29.0.60; build failures tree sitter John
2023-01-30  9:36 ` Robert Pluim
2023-01-30 11:10   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-30 11:40   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-01-30 13:17     ` Eli Zaretskii
2023-01-30 13:22       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-30 14:20         ` Eli Zaretskii
2023-01-30 14:32           ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-30 14:42           ` Robert Pluim
2023-01-30 15:00             ` Eli Zaretskii
2023-01-30 12:36 ` Eli Zaretskii
2023-01-30 13:24   ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz6w1c93.fsf@thornhill.no \
    --to=bug-gnu-emacs@gnu.org \
    --cc=61155@debbugs.gnu.org \
    --cc=jpff@codemist.co.uk \
    --cc=rpluim@gmail.com \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.