From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61155: 29.0.60; build failures tree sitter Date: Mon, 30 Jan 2023 12:40:40 +0100 Message-ID: <87cz6w1c93.fsf@thornhill.no> References: <7581-Sun29Jan2023210007+0000-jpff@codemist.co.uk> <877cx4z7lz.fsf@gmail.com> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19064"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61155@debbugs.gnu.org To: Robert Pluim , John Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 30 12:41:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMSXO-0004km-Pb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Jan 2023 12:41:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMSX3-0000YS-1s; Mon, 30 Jan 2023 06:41:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMSX1-0000Y0-0L for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 06:41:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMSX0-00034l-Nn for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 06:41:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMSX0-00054M-23 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 06:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 11:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61155 X-GNU-PR-Package: emacs Original-Received: via spool by 61155-submit@debbugs.gnu.org id=B61155.167507884619448 (code B ref 61155); Mon, 30 Jan 2023 11:41:02 +0000 Original-Received: (at 61155) by debbugs.gnu.org; 30 Jan 2023 11:40:46 +0000 Original-Received: from localhost ([127.0.0.1]:46550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMSWj-00053c-KM for submit@debbugs.gnu.org; Mon, 30 Jan 2023 06:40:45 -0500 Original-Received: from out-120.mta1.migadu.com ([95.215.58.120]:60681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMSWg-00053S-In for 61155@debbugs.gnu.org; Mon, 30 Jan 2023 06:40:44 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1675078841; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9a38r6WROgMZ78iwIRMuf4Yg3Y55kjlCZPxyggkWEJQ=; b=OMOWUkYD/n3xbVR3Qe5dRC6tX7w1/fVR+Rc9HmyxTeVaCUsAt7Oc+Nc9pcJl2CYspyjgBn KObLo7SDEUNa2ddzdqxfxjE3y3rhgPwJcQS3vGHDohFvHOb/OrC8Gkx4zM9D5FRff+jw4h jhqcCXa24+qWWmZLTKJa8ckXulXi1W72iunjji2lw9MAc47ZEIsqCUGq5RVik8JMhfJhZH A6Igaldi6VERtSGg/z10iun2sIm1itjYK2HsVDqdx4MRhl+9JfRnRfYBBiA5jK/UgEgsFD +kJ1FminD3pf+U5R1mThbThnKg3+Btg6ocaK/a9MgtwSmeovM0Uez7wi/3nn4g== In-Reply-To: <877cx4z7lz.fsf@gmail.com> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254411 Archived-At: Robert Pluim writes: >>>>>> On Sun, 29 Jan 2023 21:00:07 +0000, John said: > > John> For the last couple of days I have been unable to build emacs-29 > John> branch; error messages are > > John> In toplevel form: > John> cedet/semantic/wisent/python.el:30:2: Error: Symbol=E2=80=99s f= unction definition is void: treesit-parser-list > John> make[3]: *** [Makefile:332: cedet/semantic/wisent/python.elc] E= rror 1" > John> make[3]: Leaving directory '/home/jpff/GNU/emacs/lisp' > John> make[2]: *** [Makefile:366: compile-main] Error 2 > John> make[2]: Leaving directory '/home/jpff/GNU/emacs/lisp' > John> make[1]: *** [Makefile:533: lisp] Error 2 > John> make[1]: Leaving directory '/home/jpff/GNU/emacs' > John> make[1]: Entering directory '/home/jpff/GNU/emacs' > John> *** > John> *** "make all" failed with exit status 2. > John> *** > John> *** You could try to: > John> *** - run "make bootstrap", which might fix the problem > John> *** - run "make V=3D1", which displays the full commands invoke= d by make, > John> *** to further investigate the problem > John> *** > John> make[1]: *** [Makefile:414: advice-on-failure] Error 2 > John> make[1]: Leaving directory '/home/jpff/GNU/emacs' > > John> I do not have any tree-sitter code. "make bootstrap" appears t= o work > John> but every day it takes too much time. I read tat tree-sitter a= s not > John> necessary but this seems to contradict > > I suspect the following commit, which uses treesit-parser-list > unconditionally > > Bob> diff --git a/lisp/shell.el b/lisp/shell.el > Bob> index 5cf108bfa3b..877c48097a8 100644 > Bob> --- a/lisp/shell.el > Bob> +++ b/lisp/shell.el > Bob> @@ -366,6 +366,11 @@ shell-has-auto-cd > Bob> :group 'shell-directories > Bob> :version "28.1") >=20=20 > commit 1de6ebf2878485a0ef6b778df7d6a14d5b22a01c > Author: Theodor Thornhill > Date: Sat Jan 28 13:57:01 2023 +0100 > > Make treesit-font-lock-level a defcustom > > Robert > --=20 Can you try this and see if the error goes away? thanks, Theo diff --git a/lisp/treesit.el b/lisp/treesit.el index 92833fb007..d7e702bfb8 100644 --- a/lisp/treesit.el +++ b/lisp/treesit.el @@ -568,7 +568,7 @@ treesit--font-lock-level-setter res) (let ((buffer (car buffers))) (with-current-buffer buffer - (if (treesit-parser-list) + (if (and (treesit-available-p) (treesit-parser-list)) (loop (append res (list buffer)) (cdr buffers)) (loop res (cdr buffers)))))))) =20