all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: rpluim@gmail.com, 61155@debbugs.gnu.org, jpff@codemist.co.uk
Subject: bug#61155: 29.0.60; build failures tree sitter
Date: Mon, 30 Jan 2023 14:22:10 +0100	[thread overview]
Message-ID: <C33115BA-4707-4CEB-9264-61A3A34D8C30@thornhill.no> (raw)
In-Reply-To: <834js85fhe.fsf@gnu.org>



On 30 January 2023 14:17:17 CET, Eli Zaretskii <eliz@gnu.org> wrote:
>> Cc: 61155@debbugs.gnu.org
>> Date: Mon, 30 Jan 2023 12:40:40 +0100
>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> 
>> Can you try this and see if the error goes away?
>> 
>> thanks,
>> Theo
>> 
>> diff --git a/lisp/treesit.el b/lisp/treesit.el
>> index 92833fb007..d7e702bfb8 100644
>> --- a/lisp/treesit.el
>> +++ b/lisp/treesit.el
>> @@ -568,7 +568,7 @@ treesit--font-lock-level-setter
>>                res)
>>        (let ((buffer (car buffers)))
>>          (with-current-buffer buffer
>> -          (if (treesit-parser-list)
>> +          (if (and (treesit-available-p) (treesit-parser-list))
>>                (loop (append res (list buffer)) (cdr buffers))
>>              (loop res (cdr buffers))))))))
>
>I fixed this differently, please see the latest emacs-29 branch: I
>disabled the loop altogether.
>
>Why would we need to loop over buffers if tree-sitter is not
>available?

No need, your fix it fine, i just whipped up something quick in a break here :)

Theo





  reply	other threads:[~2023-01-30 13:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29 21:00 bug#61155: 29.0.60; build failures tree sitter John
2023-01-30  9:36 ` Robert Pluim
2023-01-30 11:10   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-30 11:40   ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-30 13:17     ` Eli Zaretskii
2023-01-30 13:22       ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-01-30 14:20         ` Eli Zaretskii
2023-01-30 14:32           ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-30 14:42           ` Robert Pluim
2023-01-30 15:00             ` Eli Zaretskii
2023-01-30 12:36 ` Eli Zaretskii
2023-01-30 13:24   ` Robert Pluim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C33115BA-4707-4CEB-9264-61A3A34D8C30@thornhill.no \
    --to=bug-gnu-emacs@gnu.org \
    --cc=61155@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=jpff@codemist.co.uk \
    --cc=rpluim@gmail.com \
    --cc=theo@thornhill.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.