From: "Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 67000@debbugs.gnu.org
Subject: bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history
Date: Thu, 04 Jan 2024 08:46:09 +0100 [thread overview]
Message-ID: <87a5pl1qym.fsf@runbox.com> (raw)
In-Reply-To: <CADwFkmmc5VZw8mD5d6xU5q4xZWa-1etXC1pJZA=cx9c0Dwhj2w@mail.gmail.com> (Stefan Kangas's message of "Thu, 14 Dec 2023 17:06:10 -0800")
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
Hi Stefan, thank you for your response.
Stefan Kangas <stefankangas@gmail.com> writes:
> - This should be called out in NEWS.
Yup, done in the revised patch attached.
> - Does it need any other documentation changes?
I don't think so; IELM is only mentioned briefly in the Emacs manual.
> - Do we usually provide options to disable this stuff?
Not as far as I can tell.
>> +(defvar ielm--history-file-name
>> + (locate-user-emacs-file "ielm-history.el")
>
> Shouldn't that be .eld?
Hm, the file will contain actual Lisp expressions, so I'd think that .el
is fitting?
-- Simen
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-support-for-reading-writing-IELM-input-history.patch --]
[-- Type: text/x-diff, Size: 2282 bytes --]
From 3ac85190a90fd85bb7a960cd4895c3bd4e41b085 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@runbox.com>
Date: Wed, 8 Nov 2023 16:08:08 +0100
Subject: [PATCH] Add support for reading/writing IELM input history
* lisp/ielm.el (inferior-emacs-lisp-mode): Add support for
reading/writing input history.
(ielm--history-file-name): Name of the file to read/write IELM input
history.
---
etc/NEWS | 5 +++++
lisp/ielm.el | 12 ++++++++++++
2 files changed, 17 insertions(+)
diff --git a/etc/NEWS b/etc/NEWS
index 1cdb12c3958..f65d53e4827 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1216,6 +1216,11 @@ chat buffers use by default.
*** New command 'customize-dirlocals'.
This command pops up a buffer to edit the settings in ".dir-locals.el".
+** IELM
+
+---
+*** IELM now remembers input history between sessions.
+
\f
* New Modes and Packages in Emacs 30.1
diff --git a/lisp/ielm.el b/lisp/ielm.el
index 777aebb70cf..46a2a1799da 100644
--- a/lisp/ielm.el
+++ b/lisp/ielm.el
@@ -152,6 +152,10 @@ ielm-header
\\[describe-mode] for help.\n"
"Message to display when IELM is started.")
+(defvar ielm--history-file-name
+ (locate-user-emacs-file "ielm-history.el")
+ "Name of the file to read/write IELM input history.")
+
(defvaralias 'inferior-emacs-lisp-mode-map 'ielm-map)
(defvar-keymap ielm-map
:doc "Keymap for IELM mode."
@@ -605,6 +609,11 @@ inferior-emacs-lisp-mode
#'ielm-indirect-setup-hook 'append t)
(setq comint-indirect-setup-function #'emacs-lisp-mode)
+ ;; Input history
+ (setq-local comint-input-ring-file-name ielm--history-file-name)
+ (setq-local kill-buffer-hook #'comint-write-input-ring)
+ (comint-read-input-ring t)
+
;; A dummy process to keep comint happy. It will never get any input
(unless (comint-check-proc (current-buffer))
;; Was cat, but on non-Unix platforms that might not exist, so
@@ -631,6 +640,9 @@ inferior-emacs-lisp-mode
(set-marker comint-last-input-start (ielm-pm))
(set-process-filter (get-buffer-process (current-buffer)) 'comint-output-filter)))
+(unless noninteractive
+ (add-hook 'kill-emacs-hook #'comint-write-input-ring))
+
(defun ielm-get-old-input nil
;; Return the previous input surrounding point
(save-excursion
--
2.39.2
next prev parent reply other threads:[~2024-01-04 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 15:11 bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-15 1:06 ` Stefan Kangas
2024-01-04 7:46 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-01-05 20:17 ` Stefan Kangas
2024-01-08 7:30 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 19:51 ` Stefan Kangas
2024-01-12 16:09 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-13 7:08 ` Stefan Kangas
2024-01-19 7:48 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-28 15:09 ` Stefan Kangas
2024-02-07 14:02 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-10 11:28 ` Stefan Kangas
2024-02-15 7:53 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5pl1qym.fsf@runbox.com \
--to=bug-gnu-emacs@gnu.org \
--cc=67000@debbugs.gnu.org \
--cc=simenheg@runbox.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.