From: "Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 67000@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history
Date: Fri, 12 Jan 2024 17:09:25 +0100 [thread overview]
Message-ID: <874jfibkju.fsf@runbox.com> (raw)
In-Reply-To: <CADwFkmmBXn2eYvKUmXMnc5LejAKo3k2dn4mOT_aaRZ44E2zQoA@mail.gmail.com> (Stefan Kangas's message of "Mon, 8 Jan 2024 11:51:39 -0800")
[-- Attachment #1: Type: text/plain, Size: 1964 bytes --]
Stefan Kangas <stefankangas@gmail.com> writes:
> On closer thought, I think this should be a defcustom.
>
> See `lua-ts-inferior-history' and `sql-input-ring-file-name' for
> example.
>
> I also think nil might as well be a valid value which disables history
> altogether (maybe users don't want that for some reason, let's say
> privacy or whatever).
>
> And the defcustom should be mentioned in NEWS, too.
Thanks, makes sense. Updated in the attached patch!
>> (defvaralias 'inferior-emacs-lisp-mode-map 'ielm-map)
>> (defvar-keymap ielm-map
>> :doc "Keymap for IELM mode."
>> @@ -605,6 +609,11 @@ inferior-emacs-lisp-mode
>> #'ielm-indirect-setup-hook 'append t)
>> (setq comint-indirect-setup-function #'emacs-lisp-mode)
>>
>> + ;; Input history
>> + (setq-local comint-input-ring-file-name ielm--history-file-name)
>> + (setq-local kill-buffer-hook #'comint-write-input-ring)
>> + (comint-read-input-ring t)
>> +
>> ;; A dummy process to keep comint happy. It will never get any input
>> (unless (comint-check-proc (current-buffer))
>> ;; Was cat, but on non-Unix platforms that might not exist, so
>> @@ -631,6 +640,9 @@ inferior-emacs-lisp-mode
>> (set-marker comint-last-input-start (ielm-pm))
>> (set-process-filter (get-buffer-process (current-buffer)) 'comint-output-filter)))
>>
>> +(unless noninteractive
>> + (add-hook 'kill-emacs-hook #'comint-write-input-ring))
>> +
>
> I'm not so sure about this part. If this is correct, why should it be
> defined here, and not, say, in comint.el? It seems like a separate,
> unrelated change. What am I missing?
Usually comint-derived modes use a process sentinel to listen to some
external process and call `comint-write-input-ring' when the process
exists, which works both the buffer is killed or Emacs itself is quit.
For IELM there is no such process to listen to, so I hook into
`kill-buffer-hook' and `kill-emacs-hook' to achieve the same things.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-support-for-reading-writing-IELM-input-history.patch --]
[-- Type: text/x-diff, Size: 2652 bytes --]
From fdfb18c16d1d38a197bc1143d2704aefa7fe9daf Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= <simenheg@runbox.com>
Date: Wed, 8 Nov 2023 16:08:08 +0100
Subject: [PATCH] Add support for reading/writing IELM input history
* lisp/ielm.el (inferior-emacs-lisp-mode): Add support for
reading/writing input history.
(ielm--history-file-name): Name of the file to read/write IELM input
history.
---
etc/NEWS | 11 +++++++++++
lisp/ielm.el | 15 +++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/etc/NEWS b/etc/NEWS
index bce33f96aee..c20d34b39ad 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -1243,6 +1243,17 @@ chat buffers use by default.
*** New command 'customize-dirlocals'.
This command pops up a buffer to edit the settings in ".dir-locals.el".
+** IELM
+
+---
+*** IELM now remembers input history between sessions.
+
+---
+*** New variable 'ielm-history-file-name'.
+If non-nil, name of the file to read/write IELM input history. Set to
+nil to revert IELM to the old behavior of not remembering input
+history between sessions.
+
\f
* New Modes and Packages in Emacs 30.1
diff --git a/lisp/ielm.el b/lisp/ielm.el
index 777aebb70cf..cfb51b7a94e 100644
--- a/lisp/ielm.el
+++ b/lisp/ielm.el
@@ -110,6 +110,13 @@ ielm-dynamic-multiline-inputs
such as `edebug-defun' to work with such inputs."
:type 'boolean)
+(defcustom ielm-history-file-name
+ (locate-user-emacs-file "ielm-history.eld")
+ "If non-nil, name of the file to read/write IELM input history."
+ :type '(choice (const :tag "nil" nil)
+ file)
+ :version "30.1")
+
(defvaralias 'inferior-emacs-lisp-mode-hook 'ielm-mode-hook)
(defcustom ielm-mode-hook nil
"Hooks to be run when IELM (`inferior-emacs-lisp-mode') is started."
@@ -605,6 +612,11 @@ inferior-emacs-lisp-mode
#'ielm-indirect-setup-hook 'append t)
(setq comint-indirect-setup-function #'emacs-lisp-mode)
+ ;; Input history
+ (setq-local comint-input-ring-file-name ielm-history-file-name)
+ (setq-local kill-buffer-hook #'comint-write-input-ring)
+ (comint-read-input-ring t)
+
;; A dummy process to keep comint happy. It will never get any input
(unless (comint-check-proc (current-buffer))
;; Was cat, but on non-Unix platforms that might not exist, so
@@ -631,6 +643,9 @@ inferior-emacs-lisp-mode
(set-marker comint-last-input-start (ielm-pm))
(set-process-filter (get-buffer-process (current-buffer)) 'comint-output-filter)))
+(unless noninteractive
+ (add-hook 'kill-emacs-hook #'comint-write-input-ring))
+
(defun ielm-get-old-input nil
;; Return the previous input surrounding point
(save-excursion
--
2.42.0
[-- Attachment #3: Type: text/plain, Size: 10 bytes --]
-- Simen
next prev parent reply other threads:[~2024-01-12 16:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 15:11 bug#67000: 30.0.50; [PATCH] Add support for reading/writing IELM input history Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-15 1:06 ` Stefan Kangas
2024-01-04 7:46 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-05 20:17 ` Stefan Kangas
2024-01-08 7:30 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-08 19:51 ` Stefan Kangas
2024-01-12 16:09 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-01-13 7:08 ` Stefan Kangas
2024-01-19 7:48 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-28 15:09 ` Stefan Kangas
2024-02-07 14:02 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-10 11:28 ` Stefan Kangas
2024-02-15 7:53 ` Simen Heggestøyl via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jfibkju.fsf@runbox.com \
--to=bug-gnu-emacs@gnu.org \
--cc=67000@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=simenheg@runbox.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.