From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#58709: 29.0.50; [PATCH] Fallout 307ad21 Date: Mon, 24 Oct 2022 22:39:38 +0300 Organization: LINKOV.NET Message-ID: <86tu3t6m59.fsf@mail.linkov.net> References: <87czal12oi.fsf@dick> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20646"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Philip Kaludercic , 58709@debbugs.gnu.org To: dick Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 24 22:05:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1on3hX-0005D9-D1 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Oct 2022 22:05:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1on3RW-0003K4-LU; Mon, 24 Oct 2022 15:49:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1on3RW-0003Jx-4F for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 15:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1on3RV-0004KJ-So for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 15:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1on3RV-0008T0-MW for bug-gnu-emacs@gnu.org; Mon, 24 Oct 2022 15:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Oct 2022 19:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58709 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58709-submit@debbugs.gnu.org id=B58709.166664088832458 (code B ref 58709); Mon, 24 Oct 2022 19:49:01 +0000 Original-Received: (at 58709) by debbugs.gnu.org; 24 Oct 2022 19:48:08 +0000 Original-Received: from localhost ([127.0.0.1]:49600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1on3Qe-0008RQ-9S for submit@debbugs.gnu.org; Mon, 24 Oct 2022 15:48:08 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:54211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1on3Qc-0008QU-2X for 58709@debbugs.gnu.org; Mon, 24 Oct 2022 15:48:06 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 927111BF206; Mon, 24 Oct 2022 19:47:57 +0000 (UTC) In-Reply-To: <87czal12oi.fsf@dick> (dick's message of "Fri, 21 Oct 2022 13:55:57 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246119 Archived-At: > Hadn't known vc-refresh-state gets into my find-file-hook > irregardless. This won't work with git branches in a detached > HEAD state. >... > (defun vc-git-working-revision (_file) > "Git-specific version of `vc-working-revision'." > (let* ((process-file-side-effects nil) > - (commit (vc-git--rev-parse "HEAD" t))) > - (or (vc-git-symbolic-commit commit) commit))) Maybe Philip could comment on this (Cc:ed). Regarding the commit 307ad21, what I noticed is that after this commit, typing 'C-c C-w' (log-edit-generate-changelog-from-diff) in log-edit mode, creates temporary buffers with names that contain symbolic revision names in their buffer names instead of hash numbers, that looks very strange.