From: Eli Zaretskii <eliz@gnu.org>
To: Mekeor Melire <mekeor@posteo.de>
Cc: 68970@debbugs.gnu.org
Subject: bug#68970: [PATCH] In Info-url-alist, add .html extension to %e format-sequence
Date: Sat, 10 Feb 2024 09:46:37 +0200 [thread overview]
Message-ID: <86jzncvk0y.fsf@gnu.org> (raw)
In-Reply-To: <87le7t2r7o.fsf@posteo.de> (message from Mekeor Melire on Fri, 09 Feb 2024 22:00:47 +0000)
> From: Mekeor Melire <mekeor@posteo.de>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 09 Feb 2024 22:00:47 +0000
>
> > I'm asking why cannot we make %e behave like your proposed %E?
>
> We can do so. I was just trying to keep URLs a little shorter, by saving
> five characters (".html"). But I think, you are right, it's more
> important to cover as many cases as possible with as few
> format-sequences as possible. Find attached a patch that implements
> this. Note that in the mean time, the fill-column has been changed for
> the Emacs repository via directory-local variables. For this patch, I
> did not use the "new" fill-column value so that the changes to the
> docstring can be seen well in the diff. Please let me know if you'd like
> the docstrings to be refilled according to the new fill-column.
From where I stand, the fill-column for commit log messages is just a
guideline, not a hard requirement. It is more important to have the
doc strings filled so they are easily readable. The hard requirements
are spelled out in CONTRIBUTE.
> --- a/lisp/info.el
> +++ b/lisp/info.el
> @@ -231,8 +231,9 @@ Info-url-alist
> MANUALs represents the name of one or more manuals. It can
> either be a string or a list of strings. URL-SPEC can be a
> string in which the substring \"%m\" will be expanded to the
> -manual-name, \"%n\" to the node-name, and \"%e\" to the
> -URL-encoded node-name (without a `.html' suffix). (The
> +manual-name and \"%n\" to the node-name. \"%e\" will expand to
^^
Two spaces between sentences, please.
> --- a/test/lisp/info-tests.el
> +++ b/test/lisp/info-tests.el
> @@ -29,17 +29,17 @@
>
> (ert-deftest test-info-urls ()
> (should (equal (Info-url-for-node "(emacs)Minibuffer")
> - "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer"))
> + "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer.html"))
> (should (equal (Info-url-for-node "(emacs)Minibuffer File")
> - "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer-File"))
> + "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer-File.html"))
> (should (equal (Info-url-for-node "(elisp)Backups and Auto-Saving")
> - "https://www.gnu.org/software/emacs/manual/html_node/elisp/Backups-and-Auto_002dSaving"))
> + "https://www.gnu.org/software/emacs/manual/html_node/elisp/Backups-and-Auto_002dSaving.html"))
> (should (equal (Info-url-for-node "(eintr)car & cdr")
> - "https://www.gnu.org/software/emacs/manual/html_node/eintr/car-_0026-cdr"))
> + "https://www.gnu.org/software/emacs/manual/html_node/eintr/car-_0026-cdr.html"))
> (should (equal (Info-url-for-node "(emacs-mime)\tIndex")
> - "https://www.gnu.org/software/emacs/manual/html_node/emacs-mime/Index"))
> + "https://www.gnu.org/software/emacs/manual/html_node/emacs-mime/Index.html"))
> (should (equal (Info-url-for-node "(gnus) Don't Panic")
> - "https://www.gnu.org/software/emacs/manual/html_node/gnus/Don_0027t-Panic"))
> + "https://www.gnu.org/software/emacs/manual/html_node/gnus/Don_0027t-Panic.html"))
> (should-error (Info-url-for-node "(nonexistent)Example")))
Should we add here tests for the Top node?
Thanks.
next prev parent reply other threads:[~2024-02-10 7:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 13:27 bug#68970: 30.0.50; Info.el: Info-url-alist should support format-sequence that encodes "Top" node as "index" Mekeor Melire
2024-02-07 14:51 ` Eli Zaretskii
2024-02-07 19:52 ` Mekeor Melire
2024-02-07 20:18 ` Eli Zaretskii
2024-02-07 22:10 ` Mekeor Melire
2024-02-08 6:26 ` Eli Zaretskii
2024-02-08 20:20 ` Mekeor Melire
2024-02-09 7:02 ` Eli Zaretskii
2024-02-09 22:00 ` bug#68970: [PATCH] In Info-url-alist, add .html extension to %e format-sequence Mekeor Melire
2024-02-10 7:46 ` Eli Zaretskii [this message]
2024-02-10 13:16 ` Mekeor Melire
2024-02-10 13:56 ` Eli Zaretskii
2024-02-10 22:41 ` bug#68970: [PATCH v2] " Mekeor Melire
2024-02-11 7:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86jzncvk0y.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68970@debbugs.gnu.org \
--cc=mekeor@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.