From: Mekeor Melire <mekeor@posteo.de>
To: 68970@debbugs.gnu.org
Cc: Eli Zaretskii <eliz@gnu.org>
Subject: bug#68970: [PATCH v2] In Info-url-alist, add .html extension to %e format-sequence
Date: Sat, 10 Feb 2024 22:41:35 +0000 [thread overview]
Message-ID: <87zfw80wh0.fsf@posteo.de> (raw)
In-Reply-To: <86r0hktocr.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
2024-02-10 15:56 eliz@gnu.org:
> if the doc string looks okay to you, there's no need to refill.
I decided to not refill the docstring.
> > > Two spaces between sentences, please.
Done.
> > > Should we add here tests for the Top node?
Done.
Find attached the new version of the patch.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-In-Info-url-alist-add-.html-extension-to-e-format-se.patch --]
[-- Type: text/x-patch, Size: 5037 bytes --]
From 7241f2ab1867f2d84c4e25c3ae5bba509718697f Mon Sep 17 00:00:00 2001
From: Mekeor Melire <mekeor@posteo.de>
Date: Fri, 9 Feb 2024 23:30:52 +0100
Subject: [PATCH] In Info-url-alist, add .html extension to %e format-sequence
* lisp/info.el (Info-url-for-node): Implement the change. (Bug#68970)
(Info-url-alist): Document the change.
* test/lisp/info-tests.el (test-info-urls): Adjust tests to account for
the change and add a test for the "Top" node.
---
lisp/info.el | 31 +++++++++++++++++--------------
test/lisp/info-tests.el | 16 +++++++++-------
2 files changed, 26 insertions(+), 21 deletions(-)
diff --git a/lisp/info.el b/lisp/info.el
index e91cc7b8e54..a6e78187e3b 100644
--- a/lisp/info.el
+++ b/lisp/info.el
@@ -231,8 +231,9 @@ Info-url-alist
MANUALs represents the name of one or more manuals. It can
either be a string or a list of strings. URL-SPEC can be a
string in which the substring \"%m\" will be expanded to the
-manual-name, \"%n\" to the node-name, and \"%e\" to the
-URL-encoded node-name (without a `.html' suffix). (The
+manual-name and \"%n\" to the node-name. \"%e\" will expand to
+the URL-encoded node-name, including the `.html' extension; in
+case of the Top node, it will expand to the empty string. (The
URL-encoding of the node-name mimics GNU Texinfo, as documented
at Info node `(texinfo)HTML Xref Node Name Expansion'.)
Alternatively, URL-SPEC can be a function which is given
@@ -1924,18 +1925,20 @@ Info-url-for-node
;; (info "(texinfo) HTML Xref Node Name Expansion")
(if (equal node "Top")
""
- (url-hexify-string
- (string-replace " " "-"
- (mapconcat
- (lambda (ch)
- (if (or (< ch 32) ; ^@^A-^Z^[^\^]^^^-
- (<= 33 ch 47) ; !"#$%&'()*+,-./
- (<= 58 ch 64) ; :;<=>?@
- (<= 91 ch 96) ; [\]_`
- (<= 123 ch 127)) ; {|}~ DEL
- (format "_00%x" ch)
- (char-to-string ch)))
- node ""))))))
+ (concat
+ (url-hexify-string
+ (string-replace " " "-"
+ (mapconcat
+ (lambda (ch)
+ (if (or (< ch 32) ; ^@^A-^Z^[^\^]^^^-
+ (<= 33 ch 47) ; !"#$%&'()*+,-./
+ (<= 58 ch 64) ; :;<=>?@
+ (<= 91 ch 96) ; [\]_`
+ (<= 123 ch 127)) ; {|}~ DEL
+ (format "_00%x" ch)
+ (char-to-string ch)))
+ node "")))
+ ".html"))))
(cond
((stringp url-spec)
(format-spec url-spec
diff --git a/test/lisp/info-tests.el b/test/lisp/info-tests.el
index 0dfdbf417e8..8020a7419cf 100644
--- a/test/lisp/info-tests.el
+++ b/test/lisp/info-tests.el
@@ -28,18 +28,20 @@
(require 'ert-x)
(ert-deftest test-info-urls ()
+ (should (equal (Info-url-for-node "(tramp)Top")
+ "https://www.gnu.org/software/emacs/manual/html_node/tramp/"))
(should (equal (Info-url-for-node "(emacs)Minibuffer")
- "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer"))
+ "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer.html"))
(should (equal (Info-url-for-node "(emacs)Minibuffer File")
- "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer-File"))
+ "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer-File.html"))
(should (equal (Info-url-for-node "(elisp)Backups and Auto-Saving")
- "https://www.gnu.org/software/emacs/manual/html_node/elisp/Backups-and-Auto_002dSaving"))
+ "https://www.gnu.org/software/emacs/manual/html_node/elisp/Backups-and-Auto_002dSaving.html"))
(should (equal (Info-url-for-node "(eintr)car & cdr")
- "https://www.gnu.org/software/emacs/manual/html_node/eintr/car-_0026-cdr"))
+ "https://www.gnu.org/software/emacs/manual/html_node/eintr/car-_0026-cdr.html"))
(should (equal (Info-url-for-node "(emacs-mime)\tIndex")
- "https://www.gnu.org/software/emacs/manual/html_node/emacs-mime/Index"))
- (should (equal (Info-url-for-node "(gnus) Don't Panic")
- "https://www.gnu.org/software/emacs/manual/html_node/gnus/Don_0027t-Panic"))
+ "https://www.gnu.org/software/emacs/manual/html_node/emacs-mime/Index.html"))
+ (should (equal (Info-url-for-node "(gnus) Don't Panic")
+ "https://www.gnu.org/software/emacs/manual/html_node/gnus/Don_0027t-Panic.html"))
(should-error (Info-url-for-node "(nonexistent)Example")))
;;; info-tests.el ends here
--
2.41.0
next prev parent reply other threads:[~2024-02-10 22:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 13:27 bug#68970: 30.0.50; Info.el: Info-url-alist should support format-sequence that encodes "Top" node as "index" Mekeor Melire
2024-02-07 14:51 ` Eli Zaretskii
2024-02-07 19:52 ` Mekeor Melire
2024-02-07 20:18 ` Eli Zaretskii
2024-02-07 22:10 ` Mekeor Melire
2024-02-08 6:26 ` Eli Zaretskii
2024-02-08 20:20 ` Mekeor Melire
2024-02-09 7:02 ` Eli Zaretskii
2024-02-09 22:00 ` bug#68970: [PATCH] In Info-url-alist, add .html extension to %e format-sequence Mekeor Melire
2024-02-10 7:46 ` Eli Zaretskii
2024-02-10 13:16 ` Mekeor Melire
2024-02-10 13:56 ` Eli Zaretskii
2024-02-10 22:41 ` Mekeor Melire [this message]
2024-02-11 7:27 ` bug#68970: [PATCH v2] " Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfw80wh0.fsf@posteo.de \
--to=mekeor@posteo.de \
--cc=68970@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.