From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#68970: [PATCH] In Info-url-alist, add .html extension to %e format-sequence Date: Sat, 10 Feb 2024 09:46:37 +0200 Message-ID: <86jzncvk0y.fsf@gnu.org> References: <87fry44bz6.fsf@posteo.de> <867cjgz5rm.fsf@gnu.org> <87bk8s3usi.fsf@posteo.de> <86le7wxc3e.fsf@gnu.org> <8734u352rm.fsf@posteo.de> <86bk8rxyia.fsf@gnu.org> <87ttmi3ar3.fsf@posteo.de> <8634u2w25i.fsf@gnu.org> <87le7t2r7o.fsf@posteo.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6169"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 68970@debbugs.gnu.org To: Mekeor Melire Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 10 08:48:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYi5p-0001Nj-Uc for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Feb 2024 08:48:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYi5U-0003be-Lq; Sat, 10 Feb 2024 02:47:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYi5T-0003bH-Fz for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 02:47:47 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYi5T-0000f2-7B for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 02:47:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYi5i-0001wN-L3 for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 02:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Feb 2024 07:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68970 X-GNU-PR-Package: emacs Original-Received: via spool by 68970-submit@debbugs.gnu.org id=B68970.17075512237265 (code B ref 68970); Sat, 10 Feb 2024 07:48:02 +0000 Original-Received: (at 68970) by debbugs.gnu.org; 10 Feb 2024 07:47:03 +0000 Original-Received: from localhost ([127.0.0.1]:49630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYi4k-0001t7-Qx for submit@debbugs.gnu.org; Sat, 10 Feb 2024 02:47:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYi4i-0001sP-PG for 68970@debbugs.gnu.org; Sat, 10 Feb 2024 02:47:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYi4N-0000Vu-TI; Sat, 10 Feb 2024 02:46:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8c9x2n2UHmh6noU5acPTly5kmPu/dpmqbrD9i2/arE4=; b=raN835mcJsz3 Yn0Q69OLkFXNXwMowv6+ySUQVtK/6AY7GfnuOdXKgsHHZfb43yrDbVHUm+/cg0I5NwuuPDmPqIek5 yGCCMT7Q5HWiRFTNTYgqh/o/EClb6NnM6CV9VmVH60CywrTVT+nfXdguY2/q5Q/g6eVcvFyQW7aU1 hG6OiOo85qHqxe+YvXF0V7GV/BhNMvB9uKMVkOFw0H0Q5Vk03pWq4jB2gasY6drYywda8hBUNNadY r5OaeRVUocGVV5aKwvRhm3PVbhhb6Q4wY7IHC9b+rLOS1LsJOk8+EcDBu5TglLOKcg6O0FE8JQIhf AwpNBtH7N7QypJxBwqR5hw==; In-Reply-To: <87le7t2r7o.fsf@posteo.de> (message from Mekeor Melire on Fri, 09 Feb 2024 22:00:47 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279722 Archived-At: > From: Mekeor Melire > Cc: Eli Zaretskii > Date: Fri, 09 Feb 2024 22:00:47 +0000 > > > I'm asking why cannot we make %e behave like your proposed %E? > > We can do so. I was just trying to keep URLs a little shorter, by saving > five characters (".html"). But I think, you are right, it's more > important to cover as many cases as possible with as few > format-sequences as possible. Find attached a patch that implements > this. Note that in the mean time, the fill-column has been changed for > the Emacs repository via directory-local variables. For this patch, I > did not use the "new" fill-column value so that the changes to the > docstring can be seen well in the diff. Please let me know if you'd like > the docstrings to be refilled according to the new fill-column. >From where I stand, the fill-column for commit log messages is just a guideline, not a hard requirement. It is more important to have the doc strings filled so they are easily readable. The hard requirements are spelled out in CONTRIBUTE. > --- a/lisp/info.el > +++ b/lisp/info.el > @@ -231,8 +231,9 @@ Info-url-alist > MANUALs represents the name of one or more manuals. It can > either be a string or a list of strings. URL-SPEC can be a > string in which the substring \"%m\" will be expanded to the > -manual-name, \"%n\" to the node-name, and \"%e\" to the > -URL-encoded node-name (without a `.html' suffix). (The > +manual-name and \"%n\" to the node-name. \"%e\" will expand to ^^ Two spaces between sentences, please. > --- a/test/lisp/info-tests.el > +++ b/test/lisp/info-tests.el > @@ -29,17 +29,17 @@ > > (ert-deftest test-info-urls () > (should (equal (Info-url-for-node "(emacs)Minibuffer") > - "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer")) > + "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer.html")) > (should (equal (Info-url-for-node "(emacs)Minibuffer File") > - "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer-File")) > + "https://www.gnu.org/software/emacs/manual/html_node/emacs/Minibuffer-File.html")) > (should (equal (Info-url-for-node "(elisp)Backups and Auto-Saving") > - "https://www.gnu.org/software/emacs/manual/html_node/elisp/Backups-and-Auto_002dSaving")) > + "https://www.gnu.org/software/emacs/manual/html_node/elisp/Backups-and-Auto_002dSaving.html")) > (should (equal (Info-url-for-node "(eintr)car & cdr") > - "https://www.gnu.org/software/emacs/manual/html_node/eintr/car-_0026-cdr")) > + "https://www.gnu.org/software/emacs/manual/html_node/eintr/car-_0026-cdr.html")) > (should (equal (Info-url-for-node "(emacs-mime)\tIndex") > - "https://www.gnu.org/software/emacs/manual/html_node/emacs-mime/Index")) > + "https://www.gnu.org/software/emacs/manual/html_node/emacs-mime/Index.html")) > (should (equal (Info-url-for-node "(gnus) Don't Panic") > - "https://www.gnu.org/software/emacs/manual/html_node/gnus/Don_0027t-Panic")) > + "https://www.gnu.org/software/emacs/manual/html_node/gnus/Don_0027t-Panic.html")) > (should-error (Info-url-for-node "(nonexistent)Example"))) Should we add here tests for the Top node? Thanks.