From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 62427@debbugs.gnu.org
Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows
Date: Wed, 17 May 2023 19:39:10 +0300 [thread overview]
Message-ID: <86ilcqnbsp.fsf@mail.linkov.net> (raw)
In-Reply-To: <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> (martin rudalics's message of "Wed, 17 May 2023 10:13:18 +0200")
>>> 1. M-x
>>> 2. C-x t 2
>>> 3. C-x o ;; switches to the minibuffer
>>> 4. C-x t 2
>>>
>>> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...")
>>> delete-other-windows-internal(#<window 4 on *Minibuf-1*> #<window 8 on *scratch*>)
>>> delete-other-windows()
>>> tab-bar-new-tab-to()
>>> tab-new(nil)
>>> funcall-interactively(tab-new nil)
>>> command-execute(tab-new)
>>
>> Does the error occur because the window configuration is broken?
>
> No. Binding 'ignore-window-parameters' to t skips the usual error
> message that you "Can't expand minibuffer to full frame". Does the
> attached patch fix it?
This is just a better error message.
After 'M-x C-x t 2', 'minibuffer-selected-window' returns non-nil that
is used in 'tab-bar-new-tab-to' before calling 'delete-other-windows':
;; Handle the case when it's called in the active minibuffer.
(when (minibuffer-selected-window)
(select-window (minibuffer-selected-window)))
The problem is that after 'M-x C-x t 2 C-x o C-x t 2',
'minibuffer-selected-window' returns nil while
the current buffer is the minibuffer.
This is because after the first 'C-x t 2', a new window is created by:
;; Create a new window to get rid of old window parameters
;; (e.g. prev/next buffers) of old window.
(split-window) (delete-window)
so 'minibuffer-selected-window' refers to the deleted window,
therefore nil.
Would it be possible to update 'minibuf_selected_window'
with a new window after deleting the original window?
next prev parent reply other threads:[~2023-05-17 16:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 21:07 bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Benson Chu
2023-03-25 19:14 ` Juri Linkov
2023-03-26 4:19 ` Eli Zaretskii
2023-03-27 7:05 ` Juri Linkov
2023-03-27 13:36 ` Eli Zaretskii
2023-03-27 16:39 ` Juri Linkov
2023-03-27 17:06 ` Eli Zaretskii
2023-03-27 17:43 ` Benson Chu
2023-03-28 12:42 ` Eli Zaretskii
2023-03-28 16:17 ` Benson Chu
2023-03-28 17:11 ` Eli Zaretskii
2023-03-28 17:39 ` Benson Chu
2023-03-30 16:43 ` Juri Linkov
2023-03-31 16:20 ` Benson Chu
2023-04-01 18:25 ` Juri Linkov
2023-04-02 18:20 ` Juri Linkov
2023-04-02 18:51 ` Juri Linkov
2023-04-15 3:03 ` Benson Chu
2023-04-15 18:42 ` Juri Linkov
2023-04-18 6:58 ` Juri Linkov
2023-04-22 9:05 ` Eli Zaretskii
2023-04-23 16:39 ` Juri Linkov
2023-04-24 11:50 ` Eli Zaretskii
2023-04-25 17:25 ` Juri Linkov
2023-05-15 17:32 ` Juri Linkov
2023-04-25 17:30 ` Juri Linkov
2023-05-16 17:32 ` Juri Linkov
2023-05-16 17:52 ` Juri Linkov
2023-05-17 8:13 ` martin rudalics
2023-05-17 16:39 ` Juri Linkov [this message]
2023-05-18 8:31 ` martin rudalics
2023-05-18 15:46 ` Juri Linkov
2023-05-19 7:31 ` martin rudalics
2023-05-19 18:14 ` Juri Linkov
2023-05-16 18:23 ` Eli Zaretskii
2023-05-17 16:32 ` Juri Linkov
2023-05-17 17:24 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ilcqnbsp.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=62427@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.