From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Date: Wed, 17 May 2023 19:39:10 +0300 Organization: LINKOV.NET Message-ID: <86ilcqnbsp.fsf@mail.linkov.net> References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <861qjgkvui.fsf@mail.linkov.net> <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4375"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 62427@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 17 19:20:53 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzKpZ-0000wH-Cy for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 May 2023 19:20:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzKon-0004vx-Dy; Wed, 17 May 2023 13:20:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzKom-0004vM-1M for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 13:20:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzKol-0007Ak-NM for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 13:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzKol-0002RZ-Ix for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 13:20:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 May 2023 17:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs Original-Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16843439959332 (code B ref 62427); Wed, 17 May 2023 17:20:03 +0000 Original-Received: (at 62427) by debbugs.gnu.org; 17 May 2023 17:19:55 +0000 Original-Received: from localhost ([127.0.0.1]:50869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKoc-0002QS-Px for submit@debbugs.gnu.org; Wed, 17 May 2023 13:19:55 -0400 Original-Received: from relay1-d.mail.gandi.net ([217.70.183.193]:35875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKoa-0002Pn-B9 for 62427@debbugs.gnu.org; Wed, 17 May 2023 13:19:52 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 7E815240002; Wed, 17 May 2023 17:19:45 +0000 (UTC) In-Reply-To: <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> (martin rudalics's message of "Wed, 17 May 2023 10:13:18 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261875 Archived-At: >>> 1. M-x >>> 2. C-x t 2 >>> 3. C-x o ;; switches to the minibuffer >>> 4. C-x t 2 >>> >>> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") >>> delete-other-windows-internal(# #) >>> delete-other-windows() >>> tab-bar-new-tab-to() >>> tab-new(nil) >>> funcall-interactively(tab-new nil) >>> command-execute(tab-new) >> >> Does the error occur because the window configuration is broken? > > No. Binding 'ignore-window-parameters' to t skips the usual error > message that you "Can't expand minibuffer to full frame". Does the > attached patch fix it? This is just a better error message. After 'M-x C-x t 2', 'minibuffer-selected-window' returns non-nil that is used in 'tab-bar-new-tab-to' before calling 'delete-other-windows': ;; Handle the case when it's called in the active minibuffer. (when (minibuffer-selected-window) (select-window (minibuffer-selected-window))) The problem is that after 'M-x C-x t 2 C-x o C-x t 2', 'minibuffer-selected-window' returns nil while the current buffer is the minibuffer. This is because after the first 'C-x t 2', a new window is created by: ;; Create a new window to get rid of old window parameters ;; (e.g. prev/next buffers) of old window. (split-window) (delete-window) so 'minibuffer-selected-window' refers to the deleted window, therefore nil. Would it be possible to update 'minibuf_selected_window' with a new window after deleting the original window?