Re: master 37889523278: Add new `swap` macro and use it

[Eli Zaretskii <eliz@gnu.org>]

> From: Po Lu <luangruo@yahoo.com>
> Cc: Dmitry Gutov <dmitry@gutov.dev>,  Richard Stallman <rms@gnu.org>,
>  emacs-devel@gnu.org
> Date: Fri, 26 Jan 2024 10:02:38 +0800
> 
> Stefan Kangas <stefankangas@gmail.com> writes:
> 
> > More importantly, I'm still waiting for someone to tell us why these
> > warnings are particularly important.  That GLib silenced them in 2018,
> > six years ago, does not really cut it.
> >
> > We don't usually go out of our way to silence all warnings on all old
> > compilers, do we?
> 
> Because I don't want to depart from GLib's practice in the PGTK port
> without reason.  We've always maintained that compiling Emacs with
> "-ansi" on GNU systems is not a suitable grounds to change our code, and
> this instance is no different.

All true, but please don't forget that the issue rears its head only
with very old compilers.  So the problem, such as it exists, is minor
at best, certainly taking into account the amount of energy we wasted
discussing it.