all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: luangruo@yahoo.com, stefankangas@gmail.com, emacs-devel@gnu.org
Subject: Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64.
Date: Thu, 08 Feb 2024 22:30:40 +0200	[thread overview]
Message-ID: <86a5oawvf3.fsf@gnu.org> (raw)
In-Reply-To: <40d7c1de-c1fa-6501-a021-4c78b51d5268@gmail.com> (message from Jim Porter on Thu, 8 Feb 2024 12:21:37 -0800)

> Date: Thu, 8 Feb 2024 12:21:37 -0800
> Cc: luangruo@yahoo.com, stefankangas@gmail.com, emacs-devel@gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
> 
> >> This, and other bullet points are all talking in the context of a single
> >> commit. But this paragraph talks about multiple ChangeLog entries within
> >> one commit (*after* the summary line and descriptive paragraph). After
> >> carefully reading this, I think it means that one ChangeLog entry is a
> >> line of the form "* some/file.el (function): Frobnicate the widget."
> > 
> > Yes.  But where did you see any verbiage to the contrary?
> 
> The first sentence of the section begins, "Ordinarily, a change you 
> commit should contain a log entry in its commit message...". That is, 
> there's just one log entry in the commit message. Here, it mentions 
> multiple entries in a single commit.

So that single use of "entry" (not "ChangeLog entry", mind you) was
what confused you?  very well, now that single instance is gone as
well.

> In practice, I think this section of CONTRIBUTE is clear enough for 
> people to understand how to properly-format their commit messages, and 
> my main confusion was in whether to account for TAB characters in the 
> ChangeLog *files* when counting columns for wrapping.

The text talks about ChangeLog entries in a commit log message, and
explicitly says "unindented", so the answer is definitely NO.

Thanks.



  reply	other threads:[~2024-02-08 20:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170727415485.32408.11264518274307262467@vcs2.savannah.gnu.org>
     [not found] ` <20240207024915.38686C0EFEC@vcs2.savannah.gnu.org>
2024-02-07 20:01   ` master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64 Stefan Kangas
2024-02-08  1:36     ` Po Lu
2024-02-08  3:10       ` Jim Porter
2024-02-08  3:34         ` Po Lu
2024-02-08  6:13           ` Jim Porter
2024-02-08  7:23             ` Eli Zaretskii
2024-02-08 17:49               ` Jim Porter
2024-02-08 19:30                 ` Eli Zaretskii
2024-02-08 20:21                   ` Jim Porter
2024-02-08 20:30                     ` Eli Zaretskii [this message]
2024-02-18  2:00           ` Stefan Kangas
2024-02-18  3:16             ` Po Lu
2024-02-18 11:36               ` bug#69223: 30.0.50; fill-column in log-edit-mode wraps ChangeLog entries incorrectly Stefan Kangas
2024-02-08  7:09         ` master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64 Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86a5oawvf3.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=luangruo@yahoo.com \
    --cc=stefankangas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.