From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) : Set to 64. Date: Thu, 08 Feb 2024 22:30:40 +0200 Message-ID: <86a5oawvf3.fsf@gnu.org> References: <170727415485.32408.11264518274307262467@vcs2.savannah.gnu.org> <20240207024915.38686C0EFEC@vcs2.savannah.gnu.org> <87plx74u0i.fsf@yahoo.com> <0e8b1009-1491-2fb7-9efc-c415ed66d334@gmail.com> <87a5ob4ok3.fsf@yahoo.com> <62ce63d3-76ce-b511-b2bf-27eb526bb711@gmail.com> <8634u3xvuq.fsf@gnu.org> <19ce18d6-3754-c755-2b1b-5fa15734b63c@gmail.com> <86cyt6wy7h.fsf@gnu.org> <40d7c1de-c1fa-6501-a021-4c78b51d5268@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29664"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, stefankangas@gmail.com, emacs-devel@gnu.org To: Jim Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 08 21:32:04 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYB3z-0007Re-O4 for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Feb 2024 21:32:03 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYB3I-00053K-Jj; Thu, 08 Feb 2024 15:31:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYB3D-000532-3w for emacs-devel@gnu.org; Thu, 08 Feb 2024 15:31:17 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYB3B-0006Fc-PT; Thu, 08 Feb 2024 15:31:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/CrgPN0dsAohGB0oGRlfc8jaLyQ1B5FY6xbDv9Ns28A=; b=dmj3mKB4ex0A +jAYo2qzQrAtZ+M8pcrFFs9zn5BCb/eOWlN3It0zE6BocihUYnx4fokbdA3mg0RSzWuJogovUGYwV H1iTBdCs9OCB3vMqcEbKISRJw2Op0A0XBdxQ3hDVnnfOXQBol12CB9pAZMng76M3RC8+Z7d6Dt8As geEGt976235keFrR80eo7hYG+gXF/Ws/X5W9rcs4NgiLnoDnm3qqlNZJpzGQDIldvnYUKM8Q4I/75 /y1MXgEL3x5yS8/l2TlT1FR1EPpFOCB//v7UatAlQJ03XK1BagT1wK2A82U15VW7LAtkemtPNO3ms Oz6C+jVkWTexa7Pk/d6C5A==; In-Reply-To: <40d7c1de-c1fa-6501-a021-4c78b51d5268@gmail.com> (message from Jim Porter on Thu, 8 Feb 2024 12:21:37 -0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316051 Archived-At: > Date: Thu, 8 Feb 2024 12:21:37 -0800 > Cc: luangruo@yahoo.com, stefankangas@gmail.com, emacs-devel@gnu.org > From: Jim Porter > > >> This, and other bullet points are all talking in the context of a single > >> commit. But this paragraph talks about multiple ChangeLog entries within > >> one commit (*after* the summary line and descriptive paragraph). After > >> carefully reading this, I think it means that one ChangeLog entry is a > >> line of the form "* some/file.el (function): Frobnicate the widget." > > > > Yes. But where did you see any verbiage to the contrary? > > The first sentence of the section begins, "Ordinarily, a change you > commit should contain a log entry in its commit message...". That is, > there's just one log entry in the commit message. Here, it mentions > multiple entries in a single commit. So that single use of "entry" (not "ChangeLog entry", mind you) was what confused you? very well, now that single instance is gone as well. > In practice, I think this section of CONTRIBUTE is clear enough for > people to understand how to properly-format their commit messages, and > my main confusion was in whether to account for TAB characters in the > ChangeLog *files* when counting columns for wrapping. The text talks about ChangeLog entries in a commit log message, and explicitly says "unindented", so the answer is definitely NO. Thanks.