From: Po Lu <luangruo@yahoo.com>
To: Jim Porter <jporterbugs@gmail.com>
Cc: Stefan Kangas <stefankangas@gmail.com>,
emacs-devel@gnu.org, eliz@gnu.org
Subject: Re: master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64.
Date: Thu, 08 Feb 2024 11:34:04 +0800 [thread overview]
Message-ID: <87a5ob4ok3.fsf@yahoo.com> (raw)
In-Reply-To: <0e8b1009-1491-2fb7-9efc-c415ed66d334@gmail.com> (Jim Porter's message of "Wed, 7 Feb 2024 19:10:14 -0800")
Jim Porter <jporterbugs@gmail.com> writes:
> Aren't the entries in ChangeLogs indented by one tab (so 8 characters
> by default), which would mean that if we want to fill the ChangeLog to
> 74 columns, we actually want log-edit-mode to fill to 74 - 8 = 66
> columns?
In the other thread, Eli stated that the correct fill-column is 65,
which is equivalent to 64 in log-edit-mode.
> That passage was last changed by Eli (CCed) in 2022 (commit
> 161cb6034cec). Previously, it said this:
True, but the definitive setting lies elsewhere, in `add-log.el':
(setq left-margin 8
fill-column 74
indent-tabs-mode t
tab-width 8
show-trailing-whitespace t)
which has existed since the beginning of time, or thereabouts.
> (There was a sentence after that recommending the first line be <=50
> columns moved elsewhere in 2021, but otherwise, that passage has been
> that way from 2015 until Eli's change.)
>
> In any case, if the intent is really to limit *ChangeLog entries* to
> 78/140 columns instead of *commit messages*, then the commit hook that
> CONTRIBUTE mentions is wrong; it checks for exceeding 78/140 columns
> in the commit message.
We wish to limit ChangeLog entries to _74_ columns, while leaving the
door open to exceeding that limit for messages that are impossible to
fill neatly within it.
> I don't have a terribly strong opinion here of what number to use, but
> we should at least resolve the inconsistencies in CONTRIBUTE,
> .dir-locals.el, and build-aux/git-hooks/commit-msg.
commit-msg is fine as-is, but CONTRIBUTE should be fixed.
next prev parent reply other threads:[~2024-02-08 3:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <170727415485.32408.11264518274307262467@vcs2.savannah.gnu.org>
[not found] ` <20240207024915.38686C0EFEC@vcs2.savannah.gnu.org>
2024-02-07 20:01 ` master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64 Stefan Kangas
2024-02-08 1:36 ` Po Lu
2024-02-08 3:10 ` Jim Porter
2024-02-08 3:34 ` Po Lu [this message]
2024-02-08 6:13 ` Jim Porter
2024-02-08 7:23 ` Eli Zaretskii
2024-02-08 17:49 ` Jim Porter
2024-02-08 19:30 ` Eli Zaretskii
2024-02-08 20:21 ` Jim Porter
2024-02-08 20:30 ` Eli Zaretskii
2024-02-18 2:00 ` Stefan Kangas
2024-02-18 3:16 ` Po Lu
2024-02-18 11:36 ` bug#69223: 30.0.50; fill-column in log-edit-mode wraps ChangeLog entries incorrectly Stefan Kangas
2024-02-08 7:09 ` master 9ccaa09a635: ; .dir-locals.el (log-edit-mode) <fill-column>: Set to 64 Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ob4ok3.fsf@yahoo.com \
--to=luangruo@yahoo.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jporterbugs@gmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.