bug#69463: 29.2; Isearch help icon has inconsistent size

bug#69463: 29.2; Isearch help icon has inconsistent size

[Sergio Callegari]

When you press CTRL+s, I-search is activated, that provides a custom
toolbar with dedicated icons and lets one enter what to search in the
mode line.

Unfortunately, in the toolbar there is a help icon, shaped as a life
buoy, that is too big or at least inconsistently big wrt the other icons.
As a consequence, when I-search is activated the emacs windows
becomes bigger to accomodate space for the taller toolbar.

Not only having the window changing its size causes some inconvenience
because the text you are trying to focus on moves up and down. There is
a major problem if the emacs window is already vertically maximized
before you start searching. In fact, in this case there is no space for
the window to grow. As a consequence, the mode line goes out of the
screen and you cannot use it to search!


In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40,
cairo version 1.18.0)
System Description: Manjaro Linux

Configured using:
  'configure --with-pgtk --with-native-compilation=aot --sysconfdir=/etc
  --prefix=/usr --libexecdir=/usr/lib --with-tree-sitter
  --localstatedir=/var --with-cairo --disable-build-details
  --with-harfbuzz --with-libsystemd --with-modules 'CFLAGS=-march=x86-64
  -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2
  -Wformat -Werror=format-security -fstack-clash-protection
  -fcf-protection -g
  -ffile-prefix-map=/build/emacs/src=/usr/src/debug/emacs -flto=auto'
  'LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -flto=auto'
  'CXXFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
  -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
  -fstack-clash-protection -fcf-protection -Wp,-D_GLIBCXX_ASSERTIONS -g
  -ffile-prefix-map=/build/emacs/src=/usr/src/debug/emacs -flto=auto''

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY
PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB

Important settings:
   value of $LC_COLLATE: en_IE.UTF-8
   value of $LC_MONETARY: en_IE.UTF-8
   value of $LC_NUMERIC: en_IE.UTF-8
   value of $LC_TIME: en_IE.UTF-8
   value of $LANG: en_US.UTF-8
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   delete-selection-mode: t
   recentf-mode: t
   cua-mode: t
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   show-paren-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   line-number-mode: t
   indent-tabs-mode: t
   transient-mark-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t

Load-path shadows:
/home/callegar/.emacs.d/elpa/jsonrpc-1.0.24/jsonrpc hides 
/usr/share/emacs/29.2/lisp/jsonrpc
/home/callegar/.emacs.d/elpa/eglot-1.17/eglot hides 
/usr/share/emacs/29.2/lisp/progmodes/eglot
/home/callegar/.emacs.d/elpa/eldoc-1.15.0/eldoc hides 
/usr/share/emacs/29.2/lisp/emacs-lisp/eldoc

Features:
(shadow sort mail-extr emacsbug message yank-media puny dired
dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config
gnus-util text-property-search time-date mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils comp comp-cstr warnings
icons cl-extra help-mode delsel recentf tree-widget wid-edit cua-base
cus-load adaptive-wrap-autoloads info auctex-autoloads tex-site
eglot-autoloads eldoc-autoloads json-mode-autoloads rx
json-snatcher-autoloads jsonrpc-autoloads markdown-mode-autoloads
package browse-url url url-proxy url-privacy url-expand url-methods
url-history url-cookie generate-lisp-file url-domsuf url-util mailcap
url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs
password-cache json subr-x map byte-opt gv bytecomp byte-compile
url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify
dynamic-setting system-font-setting font-render-setting cairo gtk pgtk
lcms2 multi-tty make-network-process native-compile emacs)

Memory information:
((conses 16 117764 9265)
  (symbols 48 10451 0)
  (strings 32 30304 1533)
  (string-bytes 1 905280)
  (vectors 16 20919)
  (vector-slots 8 416905 10928)
  (floats 8 44 53)
  (intervals 56 276 0)
  (buffers 984 11))

bug#69463: 29.2; Isearch help icon has inconsistent size

[Juri Linkov]

> When you press CTRL+s, I-search is activated, that provides a custom
> toolbar with dedicated icons and lets one enter what to search in the
> mode line.
>
> Unfortunately, in the toolbar there is a help icon, shaped as a life
> buoy, that is too big or at least inconsistently big wrt the other icons.
> As a consequence, when I-search is activated the emacs windows
> becomes bigger to accomodate space for the taller toolbar.
>
> Not only having the window changing its size causes some inconvenience
> because the text you are trying to focus on moves up and down. There is
> a major problem if the emacs window is already vertically maximized
> before you start searching. In fact, in this case there is no space for
> the window to grow. As a consequence, the mode line goes out of the
> screen and you cannot use it to search!

This behavior is system-dependent.  For example,
I can't reproduce it on these configurations:

GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu,
cairo version 1.16.0)

GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit,
cairo version 1.16.0, Xaw3d scroll bars)

GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
cairo version 1.16.0)

Strange, the last is similar to your configuration:

> In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40,
> cairo version 1.18.0)

bug#69463: 29.2; Isearch help icon has inconsistent size

[Sergio Callegari]

Can you please help me understand the way in which it is "system dependent"?

Where are the I-search toolbar icons sought on the system? Is it emacs 
installing them or are they supposed to be system or theme provided icons?

Thanks,

Sergio Callegari

On 29/02/2024 18:42, Juri Linkov wrote:
>> When you press CTRL+s, I-search is activated, that provides a custom
>> toolbar with dedicated icons and lets one enter what to search in the
>> mode line.
>>
>> Unfortunately, in the toolbar there is a help icon, shaped as a life
>> buoy, that is too big or at least inconsistently big wrt the other icons.
>> As a consequence, when I-search is activated the emacs windows
>> becomes bigger to accomodate space for the taller toolbar.
>>
>> Not only having the window changing its size causes some inconvenience
>> because the text you are trying to focus on moves up and down. There is
>> a major problem if the emacs window is already vertically maximized
>> before you start searching. In fact, in this case there is no space for
>> the window to grow. As a consequence, the mode line goes out of the
>> screen and you cannot use it to search!
> This behavior is system-dependent.  For example,
> I can't reproduce it on these configurations:
>
> GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu,
> cairo version 1.16.0)
>
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit,
> cairo version 1.16.0, Xaw3d scroll bars)
>
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
> cairo version 1.16.0)
>
> Strange, the last is similar to your configuration:
>
>> In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40,
>> cairo version 1.18.0)

bug#69463: 29.2; Isearch help icon has inconsistent size

[Sergio Callegari]

Trying to look into the matter, I have found the file
`/usr/share/emacs/29.2/lisp/isearch.el.gz`, which I understand is the 
source of the code implementing the isearch functionality.

In this file, there is a portion of code that appears to be in charge of 
configuring the toolbar, starting in
`(defvar isearch-tool-bar-map ... )`

The portion setting the icon for help should be:
```
(define-key map [isearch-describe-mode]
       (list 'menu-item "Help" 'isearch-describe-mode
             :help "Get help for Isearch"
             :image '(isearch-tool-bar-image "help")))
```

However, if I try to evaluate `(isearch-tool-bar-image "help")` I get
`/usr/share/emacs/29.2/etc/images/help.xpm`

That is definitely a life buoy, but not the life buoy that is shown as 
the help icon when I press CTRL+s. In fact, it is the life buoy that I 
see in most emacs screenshots on the internet. Most important this one 
seems to have the right size.

So my system seems to disregard the default icons shipped with emacs and 
to look for something different. My wild guess is that this depends on 
gtk theming. My second wild guess is that because I am on KDE this 
theming is not configured at all and is wrong.

To provide more context, I am on an arch derived distro (Manjaro), with 
KDE. I use the breeze theme, that seems to have exactly that too big 
life buoy.

I need help on the following points:

- Why is that breeze icon being picked? Is there a way to force emacs to 
use its own icons? Theming would be nice, but done in this way, with a 
wild mixture of breeze icons and native emacs icons it is simply messy.

- Why is that breeze icon not scaled? All other applications on my 
system appear to scale their icons consistently.

Thanks!
Sergio

On 29/02/2024 18:42, Juri Linkov wrote:
>> When you press CTRL+s, I-search is activated, that provides a custom
>> toolbar with dedicated icons and lets one enter what to search in the
>> mode line.
>>
>> Unfortunately, in the toolbar there is a help icon, shaped as a life
>> buoy, that is too big or at least inconsistently big wrt the other icons.
>> As a consequence, when I-search is activated the emacs windows
>> becomes bigger to accomodate space for the taller toolbar.
>>
>> Not only having the window changing its size causes some inconvenience
>> because the text you are trying to focus on moves up and down. There is
>> a major problem if the emacs window is already vertically maximized
>> before you start searching. In fact, in this case there is no space for
>> the window to grow. As a consequence, the mode line goes out of the
>> screen and you cannot use it to search!
> 
> This behavior is system-dependent.  For example,
> I can't reproduce it on these configurations:
> 
> GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu,
> cairo version 1.16.0)
> 
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit,
> cairo version 1.16.0, Xaw3d scroll bars)
> 
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
> cairo version 1.16.0)
> 
> Strange, the last is similar to your configuration:
> 
>> In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40,
>> cairo version 1.18.0)

bug#69463: 29.2; Isearch help icon has inconsistent size

[Sergio Callegari]

I have made more tests.

The behavior that I am experiencing is due to using the breeze icon theme.

Unclear to me if the issue is in the theme itself, though. All other 
applications using this icon theme appear to be able to scale the icons 
in the theme (which I guess are svg) according to their needs.

Sergio

On 29/02/2024 18:42, Juri Linkov wrote:
>> When you press CTRL+s, I-search is activated, that provides a custom
>> toolbar with dedicated icons and lets one enter what to search in the
>> mode line.
>>
>> Unfortunately, in the toolbar there is a help icon, shaped as a life
>> buoy, that is too big or at least inconsistently big wrt the other icons.
>> As a consequence, when I-search is activated the emacs windows
>> becomes bigger to accomodate space for the taller toolbar.
>>
>> Not only having the window changing its size causes some inconvenience
>> because the text you are trying to focus on moves up and down. There is
>> a major problem if the emacs window is already vertically maximized
>> before you start searching. In fact, in this case there is no space for
>> the window to grow. As a consequence, the mode line goes out of the
>> screen and you cannot use it to search!
> 
> This behavior is system-dependent.  For example,
> I can't reproduce it on these configurations:
> 
> GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu,
> cairo version 1.16.0)
> 
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit,
> cairo version 1.16.0, Xaw3d scroll bars)
> 
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
> cairo version 1.16.0)
> 
> Strange, the last is similar to your configuration:
> 
>> In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40,
>> cairo version 1.18.0)

bug#69463: 29.2; Isearch help icon has inconsistent size

[Sergio Callegari]

My issue seems to be the same as 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23847#31.

The whole thread is interesting.

Sergio

On 29/02/2024 18:42, Juri Linkov wrote:
>> When you press CTRL+s, I-search is activated, that provides a custom
>> toolbar with dedicated icons and lets one enter what to search in the
>> mode line.
>>
>> Unfortunately, in the toolbar there is a help icon, shaped as a life
>> buoy, that is too big or at least inconsistently big wrt the other icons.
>> As a consequence, when I-search is activated the emacs windows
>> becomes bigger to accomodate space for the taller toolbar.
>>
>> Not only having the window changing its size causes some inconvenience
>> because the text you are trying to focus on moves up and down. There is
>> a major problem if the emacs window is already vertically maximized
>> before you start searching. In fact, in this case there is no space for
>> the window to grow. As a consequence, the mode line goes out of the
>> screen and you cannot use it to search!
> 
> This behavior is system-dependent.  For example,
> I can't reproduce it on these configurations:
> 
> GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu,
> cairo version 1.16.0)
> 
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit,
> cairo version 1.16.0, Xaw3d scroll bars)
> 
> GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20,
> cairo version 1.16.0)
> 
> Strange, the last is similar to your configuration:
> 
>> In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40,
>> cairo version 1.18.0)

bug#69463: 29.2; Isearch help icon has inconsistent size

[Juri Linkov]

> Can you please help me understand the way in which it is "system dependent"?
>
> Where are the I-search toolbar icons sought on the system? Is it emacs
> installing them or are they supposed to be system or theme provided icons?

This is what I see while resizing the frame: when decreasing the width
of the frame then I-search toolbar icons get removed one by one
from the right side of the toolbar, so the toolbar never overgrows.

> That is definitely a life buoy, but not the life buoy that is shown as 
> the help icon when I press CTRL+s. In fact, it is the life buoy that I 
> see in most emacs screenshots on the internet. Most important this one 
> seems to have the right size.

I don't see this life buoy on GTK.

> I need help on the following points:
>
> - Why is that breeze icon being picked? Is there a way to force emacs to 
> use its own icons? Theming would be nice, but done in this way, with a 
> wild mixture of breeze icons and native emacs icons it is simply messy.
>
> - Why is that breeze icon not scaled? All other applications on my 
> system appear to scale their icons consistently.

I don't know how that breeze icon looks like.  What I see is
an icon with a blue question mark.

> My issue seems to be the same as
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23847#31.
> The whole thread is interesting.

Thanks for the reference.  It could help anyone
who knows how to fix this bug.

bug#69463: 29.2; Isearch help icon has inconsistent size

[Sergio Callegari]

With the hope to help others, I have managed working around the issue.
This involves going through Options->Customize Emacs->Options Matching
and then entering `x-gtk` in the modeline. In the customization buffer 
that opens, search for X Gtk Stock Map and then for 'help-browser'. 
Substitute 'help-contents' for it in "Named". Then save state so that it 
is used in the following sessions too.

Apparently, there is a lack of coordination on how icons should work 
between the breeze developers and the gnome/gtk community regarding who 
should be in charge of sizing the "scalable" icons to the correct size 
and how to pass hints about this.

My understanding is that breeze developers do not think that this is a 
bug on their side and that emacs should care of displaying the icons at 
an appropriate size.


On 03/03/2024 18:09, Juri Linkov wrote:
>> Can you please help me understand the way in which it is "system dependent"?
>>
>> Where are the I-search toolbar icons sought on the system? Is it emacs
>> installing them or are they supposed to be system or theme provided icons?
> 
> This is what I see while resizing the frame: when decreasing the width
> of the frame then I-search toolbar icons get removed one by one
> from the right side of the toolbar, so the toolbar never overgrows.
> 
>> That is definitely a life buoy, but not the life buoy that is shown as
>> the help icon when I press CTRL+s. In fact, it is the life buoy that I
>> see in most emacs screenshots on the internet. Most important this one
>> seems to have the right size.
> 
> I don't see this life buoy on GTK.
> 
>> I need help on the following points:
>>
>> - Why is that breeze icon being picked? Is there a way to force emacs to
>> use its own icons? Theming would be nice, but done in this way, with a
>> wild mixture of breeze icons and native emacs icons it is simply messy.
>>
>> - Why is that breeze icon not scaled? All other applications on my
>> system appear to scale their icons consistently.
> 
> I don't know how that breeze icon looks like.  What I see is
> an icon with a blue question mark.
> 
>> My issue seems to be the same as
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23847#31.
>> The whole thread is interesting.
> 
> Thanks for the reference.  It could help anyone
> who knows how to fix this bug.