From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sergio Callegari Newsgroups: gmane.emacs.bugs Subject: bug#69463: 29.2; Isearch help icon has inconsistent size Date: Sun, 3 Mar 2024 13:35:19 +0100 Message-ID: References: <864jdrjicr.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16539"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 69463@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 03 15:59:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rgnJk-0004Aj-Dn for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Mar 2024 15:59:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rgnJQ-0004Mr-4K; Sun, 03 Mar 2024 09:59:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgnJO-0004MQ-SC for bug-gnu-emacs@gnu.org; Sun, 03 Mar 2024 09:59:34 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rgnJO-0007Fn-Jq for bug-gnu-emacs@gnu.org; Sun, 03 Mar 2024 09:59:34 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rgnJr-0005xR-JG for bug-gnu-emacs@gnu.org; Sun, 03 Mar 2024 10:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sergio Callegari Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Mar 2024 15:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69463 X-GNU-PR-Package: emacs Original-Received: via spool by 69463-submit@debbugs.gnu.org id=B69463.170947797322746 (code B ref 69463); Sun, 03 Mar 2024 15:00:03 +0000 Original-Received: (at 69463) by debbugs.gnu.org; 3 Mar 2024 14:59:33 +0000 Original-Received: from localhost ([127.0.0.1]:40877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgnJM-0005uh-9G for submit@debbugs.gnu.org; Sun, 03 Mar 2024 09:59:32 -0500 Original-Received: from mail-ed1-f43.google.com ([209.85.208.43]:54326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgl5M-0004nW-4U for 69463@debbugs.gnu.org; Sun, 03 Mar 2024 07:36:56 -0500 Original-Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-563c595f968so5463532a12.0 for <69463@debbugs.gnu.org>; Sun, 03 Mar 2024 04:36:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709469321; x=1710074121; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4g8qpuBwKHH3VaUUsIoUUDwz0ylAHpIUcVk4+ZNOlTA=; b=UdOdEf/GmrKwCBYKJB+RybsmTzENNFy9EzT2iMPkApmFAnyZ6qG3LdBbySAdl1onOo ePwcxgfdX0F5sClc1IYyPosAgrHnuWWZbc59OOc8vrr6n/TlcTqOGYH0o2358ccBMox7 foDC6sVKhOn9KkKKCHyHivrBwGUTUcqHZdFOyqs+wjnvgTdNDtfrbrkNcgudfRdAgMhd szdwqp2SZGC4Zxg3UZuOzCEwvZ8oHW8DlEsu3nCiszcjU2q6IBcBz2gW1SSAb5N1Fsv3 6BxiKvrQjv5IITxxEGonYEQGFEo/KJZrRMmAmYpP/+MJwMDSpK/YFKMa0shs/RD9Qzsq S9wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709469321; x=1710074121; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4g8qpuBwKHH3VaUUsIoUUDwz0ylAHpIUcVk4+ZNOlTA=; b=NSa0ZmRJjxrmIKaW8U6MGvhOBXlrTvc9jWokOwH3AeP/6W/niaxJA9E/PlV+vGOxs8 0FKr4lyS7gR/VUnW+J2jOqVfeVrkvB6bypQCDlabc9jsJ89Ja6yaKxKXjsXky+zvlR7l 0WjvpqYFWWZwSqWpl6yTTtQB8f1k4vljK3sVI59mdyJSFT9W/5X88gnw9G16lB/gka3a kdZ8HVc4cOIwqEXc9/BHsdQyyRaJ5jdK/pM8kqfvzW117DsxuJoxoZnE/jisQ8Zg9/bQ +JuaXPjmCUsOLAeD/c5ZFCD3pLd+k8E1eSgyA6QmdQV5jCsCwu99WgT2wDRjug59r3/O EcsQ== X-Gm-Message-State: AOJu0YzCKBWkYs9HfzfQWbzQWFsHUNHFEaxmglE5AzCYHwTh8hHEDPgf DNLsbQTZV3dXieWgj0NIvHfH2M+vVBxKYIzCm0BZ2e6NVr1ikJL8 X-Google-Smtp-Source: AGHT+IExpgPJKZnI7bG/I2p2aSfOU8Yp5qzh288QVbFIlhkni2yDMywADGA93D0TKnfVXhpMjRaaIw== X-Received: by 2002:a05:6402:323:b0:566:4ba7:157e with SMTP id q3-20020a056402032300b005664ba7157emr4957195edw.14.1709469321071; Sun, 03 Mar 2024 04:35:21 -0800 (PST) Original-Received: from [192.168.10.195] (net-188-216-175-96.cust.vodafonedsl.it. [188.216.175.96]) by smtp.gmail.com with ESMTPSA id n24-20020a05640204d800b00566f92f1facsm1799915edw.36.2024.03.03.04.35.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Mar 2024 04:35:20 -0800 (PST) Content-Language: en-US, it-IT In-Reply-To: <864jdrjicr.fsf@mail.linkov.net> X-Mailman-Approved-At: Sun, 03 Mar 2024 09:59:30 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280936 Archived-At: Trying to look into the matter, I have found the file `/usr/share/emacs/29.2/lisp/isearch.el.gz`, which I understand is the source of the code implementing the isearch functionality. In this file, there is a portion of code that appears to be in charge of configuring the toolbar, starting in `(defvar isearch-tool-bar-map ... )` The portion setting the icon for help should be: ``` (define-key map [isearch-describe-mode] (list 'menu-item "Help" 'isearch-describe-mode :help "Get help for Isearch" :image '(isearch-tool-bar-image "help"))) ``` However, if I try to evaluate `(isearch-tool-bar-image "help")` I get `/usr/share/emacs/29.2/etc/images/help.xpm` That is definitely a life buoy, but not the life buoy that is shown as the help icon when I press CTRL+s. In fact, it is the life buoy that I see in most emacs screenshots on the internet. Most important this one seems to have the right size. So my system seems to disregard the default icons shipped with emacs and to look for something different. My wild guess is that this depends on gtk theming. My second wild guess is that because I am on KDE this theming is not configured at all and is wrong. To provide more context, I am on an arch derived distro (Manjaro), with KDE. I use the breeze theme, that seems to have exactly that too big life buoy. I need help on the following points: - Why is that breeze icon being picked? Is there a way to force emacs to use its own icons? Theming would be nice, but done in this way, with a wild mixture of breeze icons and native emacs icons it is simply messy. - Why is that breeze icon not scaled? All other applications on my system appear to scale their icons consistently. Thanks! Sergio On 29/02/2024 18:42, Juri Linkov wrote: >> When you press CTRL+s, I-search is activated, that provides a custom >> toolbar with dedicated icons and lets one enter what to search in the >> mode line. >> >> Unfortunately, in the toolbar there is a help icon, shaped as a life >> buoy, that is too big or at least inconsistently big wrt the other icons. >> As a consequence, when I-search is activated the emacs windows >> becomes bigger to accomodate space for the taller toolbar. >> >> Not only having the window changing its size causes some inconvenience >> because the text you are trying to focus on moves up and down. There is >> a major problem if the emacs window is already vertically maximized >> before you start searching. In fact, in this case there is no space for >> the window to grow. As a consequence, the mode line goes out of the >> screen and you cannot use it to search! > > This behavior is system-dependent. For example, > I can't reproduce it on these configurations: > > GNU Emacs 29.1.90 (build 1, x86_64-pc-linux-gnu, > cairo version 1.16.0) > > GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, > cairo version 1.16.0, Xaw3d scroll bars) > > GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, > cairo version 1.16.0) > > Strange, the last is similar to your configuration: > >> In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.40, >> cairo version 1.18.0)