From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries Date: Wed, 07 Sep 2022 16:27:17 +0300 Message-ID: <83wnafgvre.fsf@gnu.org> References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <87fsh4e01q.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2528"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 55039@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 07 15:28:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVv6b-0000Xi-NN for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Sep 2022 15:28:37 +0200 Original-Received: from localhost ([::1]:46742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVv6a-0008BM-GJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 07 Sep 2022 09:28:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVv62-00089f-Ne for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 09:28:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37139) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVv62-0005aW-CI for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 09:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVv61-0007zD-SX for bug-gnu-emacs@gnu.org; Wed, 07 Sep 2022 09:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Sep 2022 13:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 55039-submit@debbugs.gnu.org id=B55039.166255726230672 (code B ref 55039); Wed, 07 Sep 2022 13:28:01 +0000 Original-Received: (at 55039) by debbugs.gnu.org; 7 Sep 2022 13:27:42 +0000 Original-Received: from localhost ([127.0.0.1]:54071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVv5h-0007ye-U6 for submit@debbugs.gnu.org; Wed, 07 Sep 2022 09:27:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVv5f-0007yQ-Ko for 55039@debbugs.gnu.org; Wed, 07 Sep 2022 09:27:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVv5a-0005Wy-9F; Wed, 07 Sep 2022 09:27:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IAy74IpTYJaD21lmlhMfBnP2+scO5BabHA5PqCaw4VU=; b=c0ZEyvv3kAO/ 4C9c45sEbYDq0ElquufIAi2jaW+cAbvWg3wgU+RmK3pMKILJ+yvwxzNseaTb3oTHrRgwyOzP8Bbv4 HmFfrRiREggoWLvfjVnaKfm+CgoQXeZX9diuSDlq6hVPACks3jkDwnIIJM30p7A9vWxlXp/fd6Qrj yszyMjnBcLxxykuJ3vVwNSAJnj1Nd/hsPeIlYPkCIm5toWNl4+VuySaKL031XrF9VV98pm9B4YAL5 3v4ge+k4ds4hP1jW0dX+Y5+iKa/h5R02LKiwrGQbbkOeZZYhKkSgMcchgy59iShxMeUpjHdeRlNie xo9bt4ED/iml4xCZZEpU1Q==; Original-Received: from [87.69.77.57] (port=3059 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVv5Z-0005JY-Mh; Wed, 07 Sep 2022 09:27:34 -0400 In-Reply-To: <87fsh4e01q.fsf@posteo.net> (message from Philip Kaludercic on Tue, 06 Sep 2022 20:10:41 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241774 Archived-At: > From: Philip Kaludercic > Cc: Eli Zaretskii , 55039@debbugs.gnu.org > Date: Tue, 06 Sep 2022 20:10:41 +0000 > > --- a/doc/emacs/maintaining.texi > +++ b/doc/emacs/maintaining.texi > @@ -694,7 +694,10 @@ Log Buffer > (@code{log-edit-generate-changelog-from-diff}), to generate skeleton > ChangeLog entries, listing all changed file and function names based > on the diff of the VC fileset. Consecutive entries left empty will be > -combined by @kbd{C-q} (@code{fill-paragraph}). > +combined by @kbd{C-q} (@code{fill-paragraph}). By default the > +inserted file names will just be the files without a path. If > +@code{diff-add-log-relative-names} is non-nil, a partial path relative > +to the VC root directory will be inserted instead. GNU Coding Standards frown on using "path" for anything but PATH-style directory lists. Please use "leading directories" or somesuch here, as that's what you mean. > +*** New user option 'diff-relative-names-in-changelog'. > +If non-nil insert file names in ChangeLog skeletons relative to the ^ Comma missing there. > +(defcustom diff-add-log-relative-names nil > + "Use relative file names when generating ChangeLog messages." This doesn't say relative to what. It also doesn't mention the commands which are affected. > (defun diff-add-log-current-defuns () > "Return an alist of defun names for the current diff. > The elements of the alist are of the form (FILE . (DEFUN...)), > -where DEFUN... is a list of function names found in FILE." > +where DEFUN... is a list of function names found in FILE. If > +`diff-add-log-relative-names' is non-nil, insert file names > +relative to the VC root directory." The "insert" part is out of place here, since there's no insertion. How about If `diff-add-log-relative-names' is non-nil, file names in the alist are relative to the root directory of the VC repository. instead?