From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Foreground color opacity Date: Tue, 12 Sep 2023 05:21:41 +0300 Message-ID: <83tts0p1vu.fsf@gnu.org> References: <83fs3krhmi.fsf@gnu.org> <838r9crel3.fsf@gnu.org> <8334zkr6ll.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29253"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Filippo Argiolas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 12 04:22:17 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qft2f-0007Pd-DC for ged-emacs-devel@m.gmane-mx.org; Tue, 12 Sep 2023 04:22:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qft2O-0000Un-UP; Mon, 11 Sep 2023 22:22:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qft2M-0000UY-Mt for emacs-devel@gnu.org; Mon, 11 Sep 2023 22:21:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qft2M-0001CB-E3; Mon, 11 Sep 2023 22:21:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7ilShqYSZp3JM9lNENK1+k0by+hO77Am4afa3sw3/+s=; b=brkL5axjQVQsRpYaDLml e9WnBgNVn9+g9UtGTF8tiBmBpfpO14TE55I5eDrx/tieNYFk051BS/Q6Zl6Oab+6Nb5vSCplZeHVf 6rXVoL1xpSH/dzSUzz4jg5I0pscuPUmQ29/6iNGsP15qyn5BwILnyRJoClTOy5JiZ288OlyEhef2d XApbT/8gowrTIbHXMNmSOeo5qZ1YQj6hQFRmSe+rrFAiar/NvWHkb3ikO+BUN3AIRMXlnCAvBb2Oq +A76xqArk9arXl+bVXfoJLzjTr8mGfE9DV3m7f6HdTVlFq3tY2AstNsZlATcyj62tAqysOebBv+k8 2MdOWT/e6D4xbg==; In-Reply-To: (message from Filippo Argiolas on Mon, 11 Sep 2023 21:00:35 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310496 Archived-At: > From: Filippo Argiolas > Date: Mon, 11 Sep 2023 21:00:35 +0200 > Cc: emacs-devel@gnu.org > > On Mon, Sep 11, 2023 at 6:57 PM Eli Zaretskii wrote: > > > > > From: Filippo Argiolas > > > Date: Mon, 11 Sep 2023 18:25:50 +0200 > > > Cc: emacs-devel@gnu.org > > > > > > Didn't encounter any issue so far with c and c-ts modes but something > > > like you described could definitely happen if someone relies on font > > > face to detect symbol type. I'd say that's kind of an unsafe aspect to > > > rely on. Do you have any example in mind of code doing that so I could > > > run some tests? > > > > One such example is flyspell.el's flyspell-prog-mode. See > > flyspell-prog-text-faces there. > > Thanks! That should be easily solvable by adding > `font-lock-string-face-clangd-inactive' and the other relevant > inactive face variants to `flyspell-prog-text-faces'. > FWIW with eglot+clangd (and I guess other servers too) inactive code > regions already behave differently because they are not compiled, so > you won't get e.g. any flymake diagnostics or inlay hints, so it could > be a little less of an issue if something else like flyspell in this > case breaks. My point is that this technique _will_ break features, and I don't think it's reasonable to expect each one of them to be fixed individually.