From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55825: [PATCH] Reconvert EPUB buffers when user CSS is changed Date: Tue, 07 Jun 2022 14:06:10 +0300 Message-ID: <83pmjk7mxp.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23922"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55825@debbugs.gnu.org To: Kjartan Oli Agustsson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 07 14:02:28 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyXum-0005yV-2P for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 14:02:28 +0200 Original-Received: from localhost ([::1]:42936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyXuk-0005OA-Lj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 08:02:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyX39-0001I5-UY for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 07:07:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44640) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyX38-0006lb-LX for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 07:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyX38-0003MZ-H0 for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 07:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2022 11:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55825 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55825-submit@debbugs.gnu.org id=B55825.165459998712881 (code B ref 55825); Tue, 07 Jun 2022 11:07:02 +0000 Original-Received: (at 55825) by debbugs.gnu.org; 7 Jun 2022 11:06:27 +0000 Original-Received: from localhost ([127.0.0.1]:38535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyX2Z-0003Lg-BD for submit@debbugs.gnu.org; Tue, 07 Jun 2022 07:06:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyX2W-0003LB-Mk for 55825@debbugs.gnu.org; Tue, 07 Jun 2022 07:06:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59966) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyX2R-0006ZF-69; Tue, 07 Jun 2022 07:06:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GeAiYHljbjsrs/KC6wUEjwO3ywlbtQH2d/j0QsFUKhE=; b=XdBr6EAjblgp hvhU2pgRwXS2nC3Nif4ZOTI6CkYL5v3sTGUCGsSrYGJG4cRpsBHXQanJwdly51jacV3POwOpWGUwK eZ9m6YXtlepDSwyqKrHp5TbHaZPGrLVLNblzz5QOSLjddsJkzcAdfNPJzGSdxzkrzKHTtS/F7pALQ 2f7sZl064L2ZhenqAi6gGlGXWryWl5KLSXfmfukiIjnkLGE0SbgivkK+Zlci6D9mh2d6P0KG/dd0e OzOtwM6Qt5+9YnS8WzS8FUuU5os4bi4MIcOXT8qvPZyQ8b1tiHzedlCP832Gdzp+Bfb1QVhLKzvKE O8h2uaZRbg+icixRoSzyvg==; Original-Received: from [87.69.77.57] (port=3777 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyX2Q-0004kO-I8; Tue, 07 Jun 2022 07:06:18 -0400 In-Reply-To: (message from Kjartan Oli Agustsson on Mon, 06 Jun 2022 19:20:04 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233860 Archived-At: > From: Kjartan Oli Agustsson > Date: Mon, 06 Jun 2022 19:20:04 +0000 > > +(defun doc-view-custom-set-epub-user-stylesheet (option-name new-value) > + "Setter for `doc-view-epub-user-stylesheet'. > + > +Reconverts existing epub buffers when the file used as a user > +stylesheet is switched." > + (set-default option-name new-value) > + (file-notify-rm-watch doc-view--epub-stylesheet-watcher) > + (doc-view--epub-reconvert) > + (setq doc-view--epub-stylesheet-watcher > + (when doc-view-epub-user-stylesheet > + (file-notify-add-watch doc-view-epub-user-stylesheet '(change) #'doc-view--epub-reconvert)))) Are you sure 'change is TRT here? What kinds of changes did you want to watch in this case (it isn't clear from the doc string or the log message)? 'change is a synthetic event, and it means slightly different things with each file-notification back-end, so I wonder whether 'change is portable enough here?