all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 61188@debbugs.gnu.org, gnu@bestley.co.uk
Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Date: Tue, 31 Jan 2023 20:39:45 +0200	[thread overview]
Message-ID: <83o7qe1rbi.fsf@gnu.org> (raw)
In-Reply-To: <87wn53iq99.fsf@rub.de> (message from Stephen Berman on Mon, 30 Jan 2023 23:58:26 +0100)

> Cc: 61188@debbugs.gnu.org
> From: Stephen Berman <stephen.berman@gmx.net>
> Date: Mon, 30 Jan 2023 23:58:26 +0100
> 
> On Mon, 30 Jan 2023 21:48:20 +0000 "Mark Bestley" <gnu@bestley.co.uk> wrote:
> 
> > Look at the results of
> >
> > (require 'color)
> > (message "reduce by 100 = %s" (color-lighten-name "Black" 100))
> > (message "reduce by 0 = %s" (color-lighten-name "Black" 0))
> >
> > In emacs 28.2 they give "#ffffffffffff" and 0 as expected.
> > In emacs 30.0.50 they give 0 and 0
> 
> This difference is due to this commit:
> 
> commit 656c2dd66e77a5fbeb99d358017e8327401fae05
> Author:     Lars Ingebrigtsen <larsi@gnus.org>
> Commit:     Lars Ingebrigtsen <larsi@gnus.org>
> CommitDate: Tue Mar 22 15:28:02 2022 +0100
> 
>     Fix color-lighten-hsl logic
> 
>     * lisp/color.el (color-lighten-hsl): Lighten by percentage,
>     instead of just adding the specified number to the luminance
>     element (bug#54514).
> 
> The patch below restores the Emacs 28 result for the above examples
> while keeping the desired result for the example in bug#54514, but I
> have no idea if it yields undesirable results in other cases.

If all the tests in color-tests.el pass after the change, please
install on the release branch.

Thanks.





  reply	other threads:[~2023-01-31 18:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 21:48 bug#61188: 30.0.50; color-lighten-name seems not to work Mark Bestley
2023-01-30 22:58 ` Stephen Berman
2023-01-31 18:39   ` Eli Zaretskii [this message]
2023-01-31 20:34     ` Stephen Berman
2023-02-01 13:21       ` Eli Zaretskii
2023-02-01 14:11         ` Mark Bestley
2023-02-01 17:18           ` Eli Zaretskii
2023-02-02 15:46             ` Mark Bestley
2023-02-02 18:32               ` Mark Bestley
2023-02-21 13:08 ` Bernd Rellermeyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o7qe1rbi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=61188@debbugs.gnu.org \
    --cc=gnu@bestley.co.uk \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.