From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#61188: 30.0.50; color-lighten-name seems not to work Date: Tue, 31 Jan 2023 20:39:45 +0200 Message-ID: <83o7qe1rbi.fsf@gnu.org> References: <03DC6549-C68D-449B-92F8-BA3E9EB5AC5B@fastmail.co.uk> <87wn53iq99.fsf@rub.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32636"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61188@debbugs.gnu.org, gnu@bestley.co.uk To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 31 19:41:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMvZL-0008Jp-4i for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Jan 2023 19:41:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMvZ3-0005Bh-Ay; Tue, 31 Jan 2023 13:41:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMvZ1-0005BP-BB for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 13:41:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMvZ1-0007mE-0E for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 13:41:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMvZ0-0007tl-F1 for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 13:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Jan 2023 18:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61188 X-GNU-PR-Package: emacs Original-Received: via spool by 61188-submit@debbugs.gnu.org id=B61188.167519040230268 (code B ref 61188); Tue, 31 Jan 2023 18:41:02 +0000 Original-Received: (at 61188) by debbugs.gnu.org; 31 Jan 2023 18:40:02 +0000 Original-Received: from localhost ([127.0.0.1]:54992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMvY1-0007ry-T2 for submit@debbugs.gnu.org; Tue, 31 Jan 2023 13:40:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45342) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMvXx-0007rY-40 for 61188@debbugs.gnu.org; Tue, 31 Jan 2023 13:40:00 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMvXr-0007LY-Mx; Tue, 31 Jan 2023 13:39:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1T3TdvMwHugJA9WT5iFk0a5UDC5b9FeaWlPYAZ+bEKI=; b=dua/FVsKcUv9 bw2TGx1ZNrmk3IiZBzWqsSIvHyke8OiFZVghb/jV0REKmcccoFa7q382/XhqmGmHgqtrxzWC+c3w7 5j0aqXCe7HVxEoRBfyb5GqiinmqmJY6DE9G5OtfxAFfs1y0M0KPcnONq+BkqXPmGEY7eWvIWJSkHq p1beqILIKwSxb7sd+Y0RGkdiaFQtHVA7eM80H8GZLw577LkKvlEz+vAo7fK1fMer0AtFLkO3lP/+f gpO96IR15E2ZuQ3rnxNpR8ehZtQYhWIajftXUfMR/5cfJO+bAO3vK5RKRoPh4QOuibQ04PItWvxzO OBweJkZyB+3KtYGd0OQ3Wg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMvXp-0002A6-FQ; Tue, 31 Jan 2023 13:39:50 -0500 In-Reply-To: <87wn53iq99.fsf@rub.de> (message from Stephen Berman on Mon, 30 Jan 2023 23:58:26 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254540 Archived-At: > Cc: 61188@debbugs.gnu.org > From: Stephen Berman > Date: Mon, 30 Jan 2023 23:58:26 +0100 > > On Mon, 30 Jan 2023 21:48:20 +0000 "Mark Bestley" wrote: > > > Look at the results of > > > > (require 'color) > > (message "reduce by 100 = %s" (color-lighten-name "Black" 100)) > > (message "reduce by 0 = %s" (color-lighten-name "Black" 0)) > > > > In emacs 28.2 they give "#ffffffffffff" and 0 as expected. > > In emacs 30.0.50 they give 0 and 0 > > This difference is due to this commit: > > commit 656c2dd66e77a5fbeb99d358017e8327401fae05 > Author: Lars Ingebrigtsen > Commit: Lars Ingebrigtsen > CommitDate: Tue Mar 22 15:28:02 2022 +0100 > > Fix color-lighten-hsl logic > > * lisp/color.el (color-lighten-hsl): Lighten by percentage, > instead of just adding the specified number to the luminance > element (bug#54514). > > The patch below restores the Emacs 28 result for the above examples > while keeping the desired result for the example in bug#54514, but I > have no idea if it yields undesirable results in other cases. If all the tests in color-tests.el pass after the change, please install on the release branch. Thanks.