From: "Mark Bestley" <gnu@bestley.co.uk>
To: "Eli Zaretskii" <eliz@gnu.org>,
"Stephen Berman" <stephen.berman@gmx.net>
Cc: 61188@debbugs.gnu.org
Subject: bug#61188: 30.0.50; color-lighten-name seems not to work
Date: Wed, 01 Feb 2023 14:11:13 +0000 [thread overview]
Message-ID: <180e1ab1-287c-451b-bd43-6b858638df2f@app.fastmail.com> (raw)
In-Reply-To: <83wn51zfkh.fsf@gnu.org>
On Wed, 1 Feb 2023, at 13:21, Eli Zaretskii wrote:
>> From: Stephen Berman <stephen.berman@gmx.net>
>> Cc: gnu@bestley.co.uk, 61188@debbugs.gnu.org
>> Date: Tue, 31 Jan 2023 21:34:24 +0100
>>
>> On Tue, 31 Jan 2023 20:39:45 +0200 Eli Zaretskii <eliz@gnu.org> wrote:
>>
>> > If all the tests in color-tests.el pass after the change, please
>> > install on the release branch.
>>
>> With that patch one test now fails: the one testing (color-lighten-name
>> "Black" 100). This is because the tests were changed to conform to the
>> code change made in response to bug#54514. So it seems there is
>> disagreement about what the result of (color-lighten-name "Black" 100)
>> should be.
>
> So I guess the current behavior is the intended one, and we should
> close this bug as wontfix?
No - I think the way 28.2 worked was correct. (for impact see highlight-indent.el which now does not work with a black background )
What is the expected value of (color-lighten-name "Black" 100) as I don't know where that test is. I would think the test is wrong. Did it run for 28.2?
Surely lightening Black fully should give white
Also look at color-lighten-name "Black" 50) in 28.2 it is a gray.
In 30 olor-lighten-name "Black" of any positive value gives Black - surely this cannot be correct.
--
Mark
next prev parent reply other threads:[~2023-02-01 14:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 21:48 bug#61188: 30.0.50; color-lighten-name seems not to work Mark Bestley
2023-01-30 22:58 ` Stephen Berman
2023-01-31 18:39 ` Eli Zaretskii
2023-01-31 20:34 ` Stephen Berman
2023-02-01 13:21 ` Eli Zaretskii
2023-02-01 14:11 ` Mark Bestley [this message]
2023-02-01 17:18 ` Eli Zaretskii
2023-02-02 15:46 ` Mark Bestley
2023-02-02 18:32 ` Mark Bestley
2023-02-21 13:08 ` Bernd Rellermeyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=180e1ab1-287c-451b-bd43-6b858638df2f@app.fastmail.com \
--to=gnu@bestley.co.uk \
--cc=61188@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.