From: Eli Zaretskii <eliz@gnu.org>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] pcase.el: Add cl-type and type patterns
Date: Sun, 11 Jul 2021 09:11:17 +0300 [thread overview]
Message-ID: <83k0lxbcsa.fsf@gnu.org> (raw)
In-Reply-To: <87a6mt38fa.fsf@alphapapa.net> (message from Adam Porter on Sat, 10 Jul 2021 21:12:41 -0500)
> From: Adam Porter <adam@alphapapa.net>
> Date: Sat, 10 Jul 2021 21:12:41 -0500
>
> It seems inevitable that I discover a mistake after posting a new patch
> series. :) I corrected a mistake in the NEWS file. Please see these
> new patches.
A couple of comments about the documentation parts below. I'll leave
the main part to other reviewers.
> +@item (cl-type @var{type})
> +Matches if @var{expval} is of type @var{type}, which is a symbol or
> +list as accepted by @ref{cl-typep,,,cl,Common Lisp Extensions}.
Please don't use @ref with this "HTML-style", it produces bad results
in Info. Instead, use a slightly more wordy
... as accepted by @code{cl-typep} (@pxref{cl-typep,,,cl,Common Lisp
Extensions}).
> +Example: @code{(cl-type integer)}
> +Example: @code{(cl-type (integer 0 10))}
Examples should be in a @lisp..@end lisp block, and then you can drop
the @code markup, which is applied automatically.
> +*** Added Pcase 'cl-type' pattern.
^^^^^
"pcase", without capitalization.
Thanks.
next prev parent reply other threads:[~2021-07-11 6:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:19 [PATCH] pcase.el: Add type pattern Adam Porter
2020-03-09 18:38 ` Eli Zaretskii
2020-03-09 19:20 ` Adam Porter
2020-03-09 19:35 ` Adam Porter
2020-03-09 18:38 ` Adam Porter
2020-03-09 18:45 ` Eric Abrahamsen
2020-03-10 15:48 ` Adam Porter
2020-03-10 17:40 ` Eric Abrahamsen
2020-03-09 18:53 ` Stefan Monnier
2020-03-09 19:31 ` Adam Porter
2020-03-09 21:00 ` Stefan Monnier
2020-03-09 21:54 ` Adam Porter
2020-03-09 22:22 ` Michael Heerdegen
2020-03-09 22:46 ` Adam Porter
2020-03-10 14:54 ` Michael Heerdegen
2020-03-10 15:01 ` Michael Heerdegen
2020-03-10 15:46 ` Adam Porter
2020-03-10 16:24 ` Michael Heerdegen
2020-03-10 17:03 ` Adam Porter
2020-03-10 17:43 ` Michael Heerdegen
2020-03-10 18:04 ` Adam Porter
2020-03-10 18:17 ` Adam Porter
2020-03-10 19:07 ` Michael Heerdegen
2020-03-10 19:19 ` Adam Porter
2020-03-10 19:10 ` Eric Abrahamsen
2020-03-10 19:21 ` Adam Porter
2020-03-11 2:08 ` Michael Heerdegen
2020-03-16 12:59 ` Stefan Monnier
2021-07-11 1:33 ` [PATCH] pcase.el: Add cl-type and type patterns Adam Porter
2021-07-11 2:12 ` Adam Porter
2021-07-11 6:11 ` Eli Zaretskii [this message]
2021-07-16 9:32 ` Adam Porter
2021-07-17 11:58 ` Eli Zaretskii
2021-07-16 22:41 ` Stefan Monnier
2021-07-17 16:07 ` Adam Porter
2021-07-30 21:24 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0lxbcsa.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=adam@alphapapa.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.