From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] pcase.el: Add cl-type and type patterns Date: Sun, 11 Jul 2021 09:11:17 +0300 Message-ID: <83k0lxbcsa.fsf@gnu.org> References: <874kuxxuez.fsf@alphapapa.net> <87r1y1wcj4.fsf@alphapapa.net> <87h7yxw5x1.fsf@alphapapa.net> <87a74puq1q.fsf@web.de> <87d09lw3id.fsf@alphapapa.net> <87zhcoqmmz.fsf@web.de> <87wo7s8b73.fsf@alphapapa.net> <87eec53a8r.fsf_-_@alphapapa.net> <87a6mt38fa.fsf@alphapapa.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30829"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Adam Porter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jul 11 08:12:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m2ShE-0007uU-Qq for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Jul 2021 08:12:08 +0200 Original-Received: from localhost ([::1]:51082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2ShD-0001fy-GN for ged-emacs-devel@m.gmane-mx.org; Sun, 11 Jul 2021 02:12:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2Sgb-0000zb-3v for emacs-devel@gnu.org; Sun, 11 Jul 2021 02:11:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35196) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m2Sga-0000W2-La; Sun, 11 Jul 2021 02:11:28 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2302 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m2SgZ-0007cm-6R; Sun, 11 Jul 2021 02:11:28 -0400 In-Reply-To: <87a6mt38fa.fsf@alphapapa.net> (message from Adam Porter on Sat, 10 Jul 2021 21:12:41 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271175 Archived-At: > From: Adam Porter > Date: Sat, 10 Jul 2021 21:12:41 -0500 > > It seems inevitable that I discover a mistake after posting a new patch > series. :) I corrected a mistake in the NEWS file. Please see these > new patches. A couple of comments about the documentation parts below. I'll leave the main part to other reviewers. > +@item (cl-type @var{type}) > +Matches if @var{expval} is of type @var{type}, which is a symbol or > +list as accepted by @ref{cl-typep,,,cl,Common Lisp Extensions}. Please don't use @ref with this "HTML-style", it produces bad results in Info. Instead, use a slightly more wordy ... as accepted by @code{cl-typep} (@pxref{cl-typep,,,cl,Common Lisp Extensions}). > +Example: @code{(cl-type integer)} > +Example: @code{(cl-type (integer 0 10))} Examples should be in a @lisp..@end lisp block, and then you can drop the @code markup, which is applied automatically. > +*** Added Pcase 'cl-type' pattern. ^^^^^ "pcase", without capitalization. Thanks.