From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] pcase.el: Add type pattern
Date: Tue, 10 Mar 2020 12:10:05 -0700 [thread overview]
Message-ID: <87zhcovxf6.fsf@ericabrahamsen.net> (raw)
In-Reply-To: 87d09k8477.fsf@alphapapa.net
Adam Porter <adam@alphapapa.net> writes:
> Hi Michael,
>
> Adam Porter <adam@alphapapa.net> writes:
>
>>>> 1. Run emacs -Q.
>>>> 2. Evaluate this form in *scratch*:
>>>>
>>>> (pcase-defmacro type (type)
>>>> "Pcase pattern that matches objects of TYPE.
>>>> TYPE is a symbol or list as accepted by `cl-typep', which see."
>>>> `(pred (pcase--flip cl-typep ',type)))
>>>>
>>>> 3. Evaluate this form in *scratch*:
>>>>
>>>> (macroexpand-all '(pcase 10 ((type (integer 0 10)) t)))
>>>>
>>>> Result:
>>>>
>>>> (if (and (integerp 10) (>= 10 (quote 0)) (<= 10 (quote 10))) (progn t)
>>>> nil)
>>>
>>> No, I don't see that here. I'm using current master here.
>>
>> Hm, I don't know how to explain that. I guess I'll have to rebuild
>> master and check again.
>
> Here are the steps I just followed:
>
> 1. Pull master and rebase my patch on it.
> 2. ./configure && make && src/emacs -Q.
> 3. Evaluate this expression, in both *scratch* and M-:, which give the
> same result:
>
> (macroexpand-all '(pcase 10 ((type (integer 0 10)) t)))
>
> Result:
>
> (if (and (integerp 10) (>= 10 '0) (<= 10 '10)) (progn t) nil)
>
> I can't explain why you get a different result.
FWIW, I get the same. `if' when there's only one branch, `cond' when
there's more.
next prev parent reply other threads:[~2020-03-10 19:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 18:19 [PATCH] pcase.el: Add type pattern Adam Porter
2020-03-09 18:38 ` Eli Zaretskii
2020-03-09 19:20 ` Adam Porter
2020-03-09 19:35 ` Adam Porter
2020-03-09 18:38 ` Adam Porter
2020-03-09 18:45 ` Eric Abrahamsen
2020-03-10 15:48 ` Adam Porter
2020-03-10 17:40 ` Eric Abrahamsen
2020-03-09 18:53 ` Stefan Monnier
2020-03-09 19:31 ` Adam Porter
2020-03-09 21:00 ` Stefan Monnier
2020-03-09 21:54 ` Adam Porter
2020-03-09 22:22 ` Michael Heerdegen
2020-03-09 22:46 ` Adam Porter
2020-03-10 14:54 ` Michael Heerdegen
2020-03-10 15:01 ` Michael Heerdegen
2020-03-10 15:46 ` Adam Porter
2020-03-10 16:24 ` Michael Heerdegen
2020-03-10 17:03 ` Adam Porter
2020-03-10 17:43 ` Michael Heerdegen
2020-03-10 18:04 ` Adam Porter
2020-03-10 18:17 ` Adam Porter
2020-03-10 19:07 ` Michael Heerdegen
2020-03-10 19:19 ` Adam Porter
2020-03-10 19:10 ` Eric Abrahamsen [this message]
2020-03-10 19:21 ` Adam Porter
2020-03-11 2:08 ` Michael Heerdegen
2020-03-16 12:59 ` Stefan Monnier
2021-07-11 1:33 ` [PATCH] pcase.el: Add cl-type and type patterns Adam Porter
2021-07-11 2:12 ` Adam Porter
2021-07-11 6:11 ` Eli Zaretskii
2021-07-16 9:32 ` Adam Porter
2021-07-17 11:58 ` Eli Zaretskii
2021-07-16 22:41 ` Stefan Monnier
2021-07-17 16:07 ` Adam Porter
2021-07-30 21:24 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhcovxf6.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.