From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#61976: [elpa/yasnippet] [PATCH] Fix compilation warnings in Emacs 29 Date: Sun, 05 Mar 2023 09:29:01 +0100 Message-ID: <43894.644132682$1678005025@news.gmane.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35140"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61976@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 05 09:30:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYjl3-00090F-7j for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Mar 2023 09:30:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYjkq-0005Vw-CG; Sun, 05 Mar 2023 03:30:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYjkp-0005V8-9M for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 03:30:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYjkp-00067R-09 for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 03:30:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYjko-00071n-RV for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 03:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Mar 2023 08:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61976 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167800497226949 (code B ref -1); Sun, 05 Mar 2023 08:30:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Mar 2023 08:29:32 +0000 Original-Received: from localhost ([127.0.0.1]:38414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYjkK-00070b-5w for submit@debbugs.gnu.org; Sun, 05 Mar 2023 03:29:32 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:57898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYjkJ-00070T-5Q for submit@debbugs.gnu.org; Sun, 05 Mar 2023 03:29:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYjkI-0005Qb-0m for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 03:29:30 -0500 Original-Received: from mailtransmit05.runbox.com ([2a0c:5a00:149::26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYjkC-00063t-9T for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 03:29:29 -0500 Original-Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1pYjk5-007ng6-JM for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 09:29:17 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector2; h=Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From; bh=OgtRERRbkSNJWIaG7JyfirxnEeFmj/LAz4rE86+lE6g=; b=2mT0boDt8HJbRiX0qp4O7PFT7 94fEwE7X+6+Y5/QAdM0R2qTP4xfjVnwY3g994ViUu0+bw+ruT288dVHy4nqIEuovjzb1NmHN0CEdC jEJXAEzWlshWELv8HNkTH2VlFxUsJps7+erGM1RWGQ/JX02hqMPM3yZOUaAf5sPjHgyXHxuGGfb4U mWeSqa3RrAjqNMvb364kmB5v0jIkeSPVmS3yH2DdufQMr0eTCKI9cvG6HyJdz/Ckoo7OwfeapwPzL Ek1cL3zsFJmENgfR3Zx3PwetEIwgWNsTnBTBY9+KVJEdOM09Dym2D5lEtEbW7snva6ke2Zpysvvpg zJx0/taIQ==; Original-Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1pYjk5-0002ju-9q; Sun, 05 Mar 2023 09:29:17 +0100 Original-Received: by submission03.runbox with esmtpsa [Authenticated ID (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1pYjjq-0000CB-Je; Sun, 05 Mar 2023 09:29:02 +0100 Received-SPF: pass client-ip=2a0c:5a00:149::26; envelope-from=simenheg@runbox.com; helo=mailtransmit05.runbox.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_FROM=0.001, MSGID_MULTIPLE_AT=1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257343 Archived-At: --=-=-= Content-Type: text/plain Hi. The attached patch fixes the compilation warnings in yasnippet.el when compiling with Emacs 29. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-compilation-warnings-in-Emacs-29.patch >From a5a9254f35dd85f6b945fc274fd020e887949e07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simen=20Heggest=C3=B8yl?= Date: Sun, 5 Mar 2023 08:44:01 +0100 Subject: [PATCH] Fix compilation warnings in Emacs 29 --- yasnippet.el | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/yasnippet.el b/yasnippet.el index 78ef38ac39..0129087805 100644 --- a/yasnippet.el +++ b/yasnippet.el @@ -476,14 +476,15 @@ See also Info node `(elisp) Syntax Descriptors'.") '() "Hooks to run after a snippet exited. -The hooks will be run in an environment where some variables bound to -proper values: +The hooks will be run in an environment where some variables are +bound to proper values: `yas-snippet-beg' : The beginning of the region of the snippet. `yas-snippet-end' : Similar to beg. -Attention: These hooks are not run when exiting nested/stacked snippet expansion!") +Attention: These hooks are not run when exiting nested/stacked +snippet expansion!") (defvar yas-before-expand-snippet-hook '() @@ -555,7 +556,7 @@ conditions. sexp)) (defcustom yas-keymap-disable-hook nil - "The `yas-keymap' bindings are disabled if any function in this list returns non-nil. + "Disable `yas-keymap' bindings if any function in this list returns non-nil. This is useful to control whether snippet navigation bindings override bindings from other packages (e.g., `company-mode')." :type 'hook) @@ -1813,7 +1814,8 @@ Optional PROMPT sets the prompt to use." SNIPPETS is a list of snippet definitions, each taking the following form - (KEY TEMPLATE NAME CONDITION GROUP EXPAND-ENV LOAD-FILE KEYBINDING UUID SAVE-FILE) + (KEY TEMPLATE NAME CONDITION GROUP EXPAND-ENV LOAD-FILE + KEYBINDING UUID SAVE-FILE) Within these, only KEY and TEMPLATE are actually mandatory. @@ -2980,7 +2982,7 @@ marks it as something else (typically comment ender)." 'again)) (defun yas-longest-key-from-whitespace (start-point) - "As `yas-key-syntaxes' element, look for longest key between point and whitespace. + "As `yas-key-syntaxes' element, find longest key between point and whitespace. A newline will be considered whitespace even if the mode syntax marks it as something else (typically comment ender)." @@ -3728,8 +3730,8 @@ Use as a `:filter' argument for a conditional keybinding." "Clears unmodified field if at field start, skips to next tab. Otherwise deletes a character normally by calling `delete-char'." - (interactive) (declare (obsolete "Bind to `yas-maybe-skip-and-clear-field' instead." "0.13")) + (interactive) (cond ((yas--maybe-clear-field-filter t) (yas--skip-and-clear (or field (yas-current-field))) (yas-next-field 1)) @@ -4740,9 +4742,11 @@ The following count as a field: * \"${n: text}\", for a numbered field with default text, as long as N is not 0; * \"${n: text$(expression)}, the same with a Lisp expression; - this is caught with the curiously named `yas--multi-dollar-lisp-expression-regexp' + this is caught with the curiously named + `yas--multi-dollar-lisp-expression-regexp' -* the same as above but unnumbered, (no N:) and number is calculated automatically. +* the same as above but unnumbered, (no N:) and number is + calculated automatically. When multiple expressions are found, only the last one counts." ;; -- 2.39.1 --=-=-= Content-Type: text/plain -- Simen --=-=-=--