From: Gregory Heytings <gregory@heytings.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master d0a66f3e0e: Display a warning for some uses of nil in face attributes.
Date: Sun, 27 Nov 2022 18:04:25 +0000 [thread overview]
Message-ID: <3d2972a5f544f212c6c6@heytings.org> (raw)
In-Reply-To: <CADwFkmkYCYpB69GTcHz9-A9h3iVrodOGjRT_Ug5T-abU4eNTyg@mail.gmail.com>
>
> But should the newly introduced warning be called out in NEWS?
>
I don't think so, the nil value there was supported for compatibility with
Emacs 20 but was not documented (and the message seems clear enough).
>
> Also, why not make this into a function? Is it performance critical
> enough to warrant using a macro?
>
It's not a macro for performance reasons, it's a macro because it didn't
seem worth to me to make it a function.
next prev parent reply other threads:[~2022-11-27 18:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166215065969.27647.10737851450469499017@vcs2.savannah.gnu.org>
[not found] ` <20220902203100.0C8D8C0088A@vcs2.savannah.gnu.org>
2022-11-27 17:07 ` master d0a66f3e0e: Display a warning for some uses of nil in face attributes Stefan Kangas
2022-11-27 18:04 ` Gregory Heytings [this message]
2022-11-27 18:20 ` Stefan Kangas
2022-11-27 18:39 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d2972a5f544f212c6c6@heytings.org \
--to=gregory@heytings.org \
--cc=emacs-devel@gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.