From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.devel Subject: Re: master d0a66f3e0e: Display a warning for some uses of nil in face attributes. Date: Sun, 27 Nov 2022 18:04:25 +0000 Message-ID: <3d2972a5f544f212c6c6@heytings.org> References: <166215065969.27647.10737851450469499017@vcs2.savannah.gnu.org> <20220902203100.0C8D8C0088A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8351"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 27 19:05:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozM29-0001tU-9d for ged-emacs-devel@m.gmane-mx.org; Sun, 27 Nov 2022 19:05:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozM16-0001j2-2a; Sun, 27 Nov 2022 13:04:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozM0z-0001iI-Db for emacs-devel@gnu.org; Sun, 27 Nov 2022 13:04:29 -0500 Original-Received: from heytings.org ([95.142.160.155]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozM0y-0006dO-0r for emacs-devel@gnu.org; Sun, 27 Nov 2022 13:04:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1669572265; bh=4vOseox8axEIS4LDdLqAMHr5dh1MbPnpoU7midWQa9c=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=5VQRBqVkcKjag5f8EgIRy3BRQ0Saaoksv6fYYeOf5JVYY/W1Fnfgi08iL9TA4U7jm P5JmPNjl8Way4JFEbrjff/RTmRV9FFob3i33p/WykPZUMIbB3Xcnpf4mfMkSkhw8nf AUsO1PGCs2Q+OW8UK4vPUc1JDBG4WVBA6qIfa3BWoxlg6atoWmBo91nYcw9JjHItr5 JG5+M1RRPJWBQr1x1zbNZJjG1iobzdETWfpGa8YolO62j+lptS7DRb1Q6ZHySpfhBB AfyUbV+KlJabmaXA+M53U1KeqiwSmGUVmIpWuqRN2jRcWl9+oIVRRlLAKzAiMPhVPF T196LN+zoRFXQ== In-Reply-To: Received-SPF: pass client-ip=95.142.160.155; envelope-from=gregory@heytings.org; helo=heytings.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300636 Archived-At: > > But should the newly introduced warning be called out in NEWS? > I don't think so, the nil value there was supported for compatibility with Emacs 20 but was not documented (and the message seems clear enough). > > Also, why not make this into a function? Is it performance critical > enough to warrant using a macro? > It's not a macro for performance reasons, it's a macro because it didn't seem worth to me to make it a function.