all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefankangas@gmail.com>
To: Gregory Heytings <gregory@heytings.org>, emacs-devel@gnu.org
Subject: Re: master d0a66f3e0e: Display a warning for some uses of nil in face attributes.
Date: Sun, 27 Nov 2022 09:07:52 -0800	[thread overview]
Message-ID: <CADwFkmkYCYpB69GTcHz9-A9h3iVrodOGjRT_Ug5T-abU4eNTyg@mail.gmail.com> (raw)
In-Reply-To: <20220902203100.0C8D8C0088A@vcs2.savannah.gnu.org>

Gregory Heytings <gregory@heytings.org> writes:

> branch: master
> commit d0a66f3e0e668d8c12c54436740c62f8e238a664
> Author: Gregory Heytings <gregory@heytings.org>
> Commit: Gregory Heytings <gregory@heytings.org>
>
>     Display a warning for some uses of nil in face attributes.
>
>     * src/xfaces.c (HANDLE_INVALID_NIL_VALUE): New macro, which displays
>     a warning for invalid uses of nil as a face attribute value.
>     (Finternal_set_lisp_face_attribute): Use the macro for the attributes
>     :foreground, :distant-foreground and :background.
> ---
>  src/xfaces.c | 21 ++++++++++++---------
>  1 file changed, 12 insertions(+), 9 deletions(-)
>
> diff --git a/src/xfaces.c b/src/xfaces.c
> index 70d5cbeb4c..5e3a47d7f8 100644
> --- a/src/xfaces.c
> +++ b/src/xfaces.c
> @@ -3052,6 +3052,15 @@ The value is TO.  */)
>  }
>
>
> +#define HANDLE_INVALID_NIL_VALUE(A,F)					\
> +  if (NILP (value))							\
> +    {									\
> +      add_to_log ("Warning: setting attribute `%s' of face `%s': nil "	\
> +		  "value is invalid, use `unspecified' instead.", A, F); \
> +      /* Compatibility with 20.x.  */					\
> +      value = Qunspecified;						\
> +    }
> +

Thanks, it makes sense to warn users using Emacs 20 face specifications.

But should the newly introduced warning be called out in NEWS?

Also, why not make this into a function?  Is it performance critical
enough to warrant using a macro?

>  DEFUN ("internal-set-lisp-face-attribute", Finternal_set_lisp_face_attribute,
>         Sinternal_set_lisp_face_attribute, 3, 4, 0,
>         doc: /* Set attribute ATTR of FACE to VALUE.
> @@ -3390,9 +3399,7 @@ FRAME 0 means change the face on all frames, and change the default
>      }
>    else if (EQ (attr, QCforeground))
>      {
> -      /* Compatibility with 20.x.  */
> -      if (NILP (value))
> -	value = Qunspecified;
> +      HANDLE_INVALID_NIL_VALUE (QCforeground, face);
>        if (!UNSPECIFIEDP (value)
>  	  && !IGNORE_DEFFACE_P (value)
>  	  && !RESET_P (value))
> @@ -3409,9 +3416,7 @@ FRAME 0 means change the face on all frames, and change the default
>      }
>    else if (EQ (attr, QCdistant_foreground))
>      {
> -      /* Compatibility with 20.x.  */
> -      if (NILP (value))
> -	value = Qunspecified;
> +      HANDLE_INVALID_NIL_VALUE (QCdistant_foreground, face);
>        if (!UNSPECIFIEDP (value)
>  	  && !IGNORE_DEFFACE_P (value)
>  	  && !RESET_P (value))
> @@ -3428,9 +3433,7 @@ FRAME 0 means change the face on all frames, and change the default
>      }
>    else if (EQ (attr, QCbackground))
>      {
> -      /* Compatibility with 20.x.  */
> -      if (NILP (value))
> -	value = Qunspecified;
> +      HANDLE_INVALID_NIL_VALUE (QCbackground, face);
>        if (!UNSPECIFIEDP (value)
>  	  && !IGNORE_DEFFACE_P (value)
>  	  && !RESET_P (value))



       reply	other threads:[~2022-11-27 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <166215065969.27647.10737851450469499017@vcs2.savannah.gnu.org>
     [not found] ` <20220902203100.0C8D8C0088A@vcs2.savannah.gnu.org>
2022-11-27 17:07   ` Stefan Kangas [this message]
2022-11-27 18:04     ` master d0a66f3e0e: Display a warning for some uses of nil in face attributes Gregory Heytings
2022-11-27 18:20       ` Stefan Kangas
2022-11-27 18:39         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADwFkmkYCYpB69GTcHz9-A9h3iVrodOGjRT_Ug5T-abU4eNTyg@mail.gmail.com \
    --to=stefankangas@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=gregory@heytings.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.