From: Yuan Fu <casouri@gmail.com>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 59904-done@debbugs.gnu.org,
"Jostein Kjønigsen" <jostein@secure.kjonigsen.net>
Subject: bug#59904: 29.0.60; js-ts-mode does not fontify method-call to object-instances using font-lock-function-name
Date: Fri, 9 Dec 2022 12:53:28 -0800 [thread overview]
Message-ID: <2820BE0C-EB44-40DF-98D3-CF49F87A4A54@gmail.com> (raw)
In-Reply-To: <2657cf47-c2af-eeba-265f-3249b9f38e4c@secure.kjonigsen.net>
Theodor Thornhill <theo@thornhill.no> writes:
> Jostein Kjønigsen <jostein@secure.kjonigsen.net> writes:
>
>> Looking into the code, a minimal code-repro looks like this:
>>
>> someObject.someMethod();
>>
>> Activating treesit-explore-mode on that, yields the following tree:
>>
>> (expression_statement
>> (call_expression
>> function: (member_expression object: (identifier) . property:
>> (property_identifier))
>> arguments: (arguments ( )))
>> ;)
>>
>> Now looking in js.el I see the following which looks like it's trying to
>> fontify this, but for some reason it's not working:
>>
>> (call_expression
>> function: [(identifier) @font-lock-function-name-face
>> (member_expression
>> property:
>> (property_identifier) @font-lock-function-name-face)])
>>
>> I'm guessing this fontification is being overridden further down (just
>> like for csharp-ts-mode). From what I can tell, reversing the order of
>> declarations seems to fix this for me.
>>
>
> Yeah this is probably correct. Looks good to me. Yuan, want to apply?
> :-)
>
> Theo
Applied, thanks! I added a comment so we don’t accidentally reintroduce
this later.
Yuan
prev parent reply other threads:[~2022-12-09 20:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 13:56 bug#59904: 29.0.60; js-ts-mode does not fontify method-call to object-instances using font-lock-function-name Jostein Kjønigsen
2022-12-08 14:46 ` Jostein Kjønigsen
2022-12-08 15:02 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-09 20:53 ` Yuan Fu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2820BE0C-EB44-40DF-98D3-CF49F87A4A54@gmail.com \
--to=casouri@gmail.com \
--cc=59904-done@debbugs.gnu.org \
--cc=jostein@secure.kjonigsen.net \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.