From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59904: 29.0.60; js-ts-mode does not fontify method-call to object-instances using font-lock-function-name Date: Fri, 9 Dec 2022 12:53:28 -0800 Message-ID: <2820BE0C-EB44-40DF-98D3-CF49F87A4A54@gmail.com> References: <2657cf47-c2af-eeba-265f-3249b9f38e4c@secure.kjonigsen.net> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24120"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59904-done@debbugs.gnu.org, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 09 21:54:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3kNy-000645-Dy for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 09 Dec 2022 21:54:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3kNf-0006NU-KK; Fri, 09 Dec 2022 15:54:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3kNe-0006ND-Ds for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 15:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p3kNe-0000wU-4s for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 15:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p3kNd-0005W5-WB for bug-gnu-emacs@gnu.org; Fri, 09 Dec 2022 15:54:02 -0500 In-Reply-To: <2657cf47-c2af-eeba-265f-3249b9f38e4c@secure.kjonigsen.net> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Dec 2022 20:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 59904 X-GNU-PR-Package: emacs Mail-Followup-To: 59904@debbugs.gnu.org, casouri@gmail.com, jostein@secure.kjonigsen.net Original-Received: via spool by 59904-done@debbugs.gnu.org id=D59904.167061922021192 (code D ref 59904); Fri, 09 Dec 2022 20:54:01 +0000 Original-Received: (at 59904-done) by debbugs.gnu.org; 9 Dec 2022 20:53:40 +0000 Original-Received: from localhost ([127.0.0.1]:38435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kNH-0005Vk-PH for submit@debbugs.gnu.org; Fri, 09 Dec 2022 15:53:40 -0500 Original-Received: from mail-pl1-f181.google.com ([209.85.214.181]:44016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p3kNF-0005Vb-Rb for 59904-done@debbugs.gnu.org; Fri, 09 Dec 2022 15:53:38 -0500 Original-Received: by mail-pl1-f181.google.com with SMTP id d3so6105737plr.10 for <59904-done@debbugs.gnu.org>; Fri, 09 Dec 2022 12:53:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=lOHDUvDANlzfrw/QpOPrc1IEV30VkPv4weekXQ9dT3o=; b=jCheliwHEVMEfGYfbdDeLmTB7GvxdligvNNKj1kZAJ8FIuLq8S0Vn+8dyS530tyF9/ 4SflaMKnHCk/+KrS+xscK3cyhtLRc140z2rvo44ZlvWzZ/e3lvANXr8i9o31Chwr/ru3 z99N6WWgmqTjNY4lRr/WNCDgt5nMtG8ngLCIfICRbKvY65ETdScLqNMOKfTBQ7svp7YU +SRdY5YEzmxG3AqO9skHeLVuVBmVpkrhQIe1//XQPOPht5jSmklkvbAGmExT/O+Nz4un VimcFLGUTo9TIubE62/Zxko0+WUjdExUEMzpXZMKrkoB31F/55oSkaPp0s98lkw1z8iT Yb5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lOHDUvDANlzfrw/QpOPrc1IEV30VkPv4weekXQ9dT3o=; b=QNdazl7TzbAXrxVSd6oR/5/3/sGnMvSWsU4AzxVm6tMgm65h5I+kkcFyfDwwlNBkc3 Ltx7LiiR0CImO65TSnAv0xwI0zbFlOZE0iy3JSLck/Zzz4xOCGqQZd495Ua6RoluynfQ THWcCFML7YXVeVpT4PsEYlmasXoi8LO8zHPN6WshSPG+Q2xIm3h8cnuCopAcsd/xuO5R eraQ22EcQt2wZD50660jjPSrMpEwCC3jRQSdLL0Ic3c6lhTfYpQ5qzKZrQd+pe0jOZg2 NirfZ5z7mV26AY5k6yQzLBcuvlfmEhpf9QQxNI9lb/gUX/GXUjztW7ykKEK0XCkx1SvI P5TA== X-Gm-Message-State: ANoB5pl0AWCjdpRIUESXvngafTJI8XLgwX4wxrnN4sDipjHKdmboclGD nFoH36H433MH+2dK2HaVkm8= X-Google-Smtp-Source: AA0mqf7XQKrRypq7xEWEbVSI49GpTeCuzxVWC2pzVkDa0DEp6kkPzoMYYElBTy4fO/so4YsbXmoOFQ== X-Received: by 2002:a17:90a:bd86:b0:219:f072:f4d8 with SMTP id z6-20020a17090abd8600b00219f072f4d8mr8332011pjr.11.1670619211917; Fri, 09 Dec 2022 12:53:31 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id mj4-20020a17090b368400b002191873187dsm1595658pjb.33.2022.12.09.12.53.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Dec 2022 12:53:31 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250457 Archived-At: Theodor Thornhill writes: > Jostein Kj=C3=B8nigsen writes: > >> Looking into the code, a minimal code-repro looks like this: >> >> someObject.someMethod(); >> >> Activating treesit-explore-mode on that, yields the following tree: >> >> (expression_statement >> (call_expression >> function: (member_expression object: (identifier) . property:=20 >> (property_identifier)) >> arguments: (arguments ( ))) >> ;) >> >> Now looking in js.el I see the following which looks like it's trying = to=20 >> fontify this, but for some reason it's not working: >> >> (call_expression >> function: [(identifier) @font-lock-function-name-face >> (member_expression >> property: >> (property_identifier) = @font-lock-function-name-face)]) >> >> I'm guessing this fontification is being overridden further down = (just=20 >> like for csharp-ts-mode). =46rom what I can tell, reversing the order = of=20 >> declarations seems to fix this for me. >> > > Yeah this is probably correct. Looks good to me. Yuan, want to = apply? > :-) > > Theo Applied, thanks! I added a comment so we don=E2=80=99t accidentally = reintroduce this later. Yuan