* [PATCH] erc-track erases the modeline when new buffers are created
@ 2010-08-13 22:57 Antoine Levitt
2011-01-31 18:16 ` Michael Olson
0 siblings, 1 reply; 5+ messages in thread
From: Antoine Levitt @ 2010-08-13 22:57 UTC (permalink / raw)
To: emacs-devel
When a new ERC buffer is created (for instance, a query) while erc-track
displays information in the mode line, the information is removed. I
tracked the bug down to an initialisation of
erc-modified-channels-object each time erc-track-mode is activated (ie,
each time an ERC buffer is created). This is useless because the
variable is initialised at load time with (defvar).
This patch simply removes the extra initialisation. I tested it, it
works for me and I don't see any potential bugs the removal might cause.
Antoine Levitt
=== modified file 'lisp/erc/erc-track.el'
--- lisp/erc/erc-track.el 2010-01-13 08:35:10 +0000
+++ lisp/erc/erc-track.el 2010-08-13 22:47:20 +0000
@@ -649,7 +649,6 @@
(add-hook 'erc-send-completed-hook 'erc-user-is-active)
(add-hook 'erc-server-001-functions 'erc-user-is-active))
(erc-track-add-to-mode-line erc-track-position-in-mode-line)
- (setq erc-modified-channels-object (erc-modified-channels-object nil))
(erc-update-mode-line)
(if (featurep 'xemacs)
(defadvice switch-to-buffer (after erc-update (&rest args) activate)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] erc-track erases the modeline when new buffers are created
@ 2011-01-28 22:58 Thomas Riccardi
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Riccardi @ 2011-01-28 22:58 UTC (permalink / raw)
To: emacs-devel
I confirm that the bug exists and the proposed patch works for me too.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] erc-track erases the modeline when new buffers are created
2010-08-13 22:57 Antoine Levitt
@ 2011-01-31 18:16 ` Michael Olson
2011-01-31 19:16 ` Chong Yidong
2011-01-31 19:27 ` Chong Yidong
0 siblings, 2 replies; 5+ messages in thread
From: Michael Olson @ 2011-01-31 18:16 UTC (permalink / raw)
To: Antoine Levitt; +Cc: emacs-devel
Looks good to me.
On Fri, Aug 13, 2010 at 3:57 PM, Antoine Levitt
<antoine.levitt@gmail.com> wrote:
> When a new ERC buffer is created (for instance, a query) while erc-track
> displays information in the mode line, the information is removed. I
> tracked the bug down to an initialisation of
> erc-modified-channels-object each time erc-track-mode is activated (ie,
> each time an ERC buffer is created). This is useless because the
> variable is initialised at load time with (defvar).
>
> This patch simply removes the extra initialisation. I tested it, it
> works for me and I don't see any potential bugs the removal might cause.
>
> Antoine Levitt
>
> === modified file 'lisp/erc/erc-track.el'
> --- lisp/erc/erc-track.el 2010-01-13 08:35:10 +0000
> +++ lisp/erc/erc-track.el 2010-08-13 22:47:20 +0000
> @@ -649,7 +649,6 @@
> (add-hook 'erc-send-completed-hook 'erc-user-is-active)
> (add-hook 'erc-server-001-functions 'erc-user-is-active))
> (erc-track-add-to-mode-line erc-track-position-in-mode-line)
> - (setq erc-modified-channels-object (erc-modified-channels-object nil))
> (erc-update-mode-line)
> (if (featurep 'xemacs)
> (defadvice switch-to-buffer (after erc-update (&rest args) activate)
>
>
>
--
Michael Olson | http://mwolson.org/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] erc-track erases the modeline when new buffers are created
2011-01-31 18:16 ` Michael Olson
@ 2011-01-31 19:16 ` Chong Yidong
2011-01-31 19:27 ` Chong Yidong
1 sibling, 0 replies; 5+ messages in thread
From: Chong Yidong @ 2011-01-31 19:16 UTC (permalink / raw)
To: Michael Olson; +Cc: emacs-devel, Antoine Levitt
Michael Olson <mwolson@gnu.org> writes:
> Looks good to me.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] erc-track erases the modeline when new buffers are created
2011-01-31 18:16 ` Michael Olson
2011-01-31 19:16 ` Chong Yidong
@ 2011-01-31 19:27 ` Chong Yidong
1 sibling, 0 replies; 5+ messages in thread
From: Chong Yidong @ 2011-01-31 19:27 UTC (permalink / raw)
To: Michael Olson; +Cc: emacs-devel, Antoine Levitt
Michael Olson <mwolson@gnu.org> writes:
> Looks good to me.
Thank, committed.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-01-31 19:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-28 22:58 [PATCH] erc-track erases the modeline when new buffers are created Thomas Riccardi
-- strict thread matches above, loose matches on Subject: below --
2010-08-13 22:57 Antoine Levitt
2011-01-31 18:16 ` Michael Olson
2011-01-31 19:16 ` Chong Yidong
2011-01-31 19:27 ` Chong Yidong
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.