From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Olson Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] erc-track erases the modeline when new buffers are created Date: Mon, 31 Jan 2011 10:16:14 -0800 Message-ID: References: <87r5i26s01.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1296497817 6863 80.91.229.12 (31 Jan 2011 18:16:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 31 Jan 2011 18:16:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Antoine Levitt Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 31 19:16:53 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PjyJ2-0007ok-C7 for ged-emacs-devel@m.gmane.org; Mon, 31 Jan 2011 19:16:53 +0100 Original-Received: from localhost ([127.0.0.1]:37149 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjyIz-000126-K6 for ged-emacs-devel@m.gmane.org; Mon, 31 Jan 2011 13:16:49 -0500 Original-Received: from [140.186.70.92] (port=44182 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PjyIp-0000xv-1n for emacs-devel@gnu.org; Mon, 31 Jan 2011 13:16:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PjyIn-0006ba-BQ for emacs-devel@gnu.org; Mon, 31 Jan 2011 13:16:38 -0500 Original-Received: from mail-iy0-f169.google.com ([209.85.210.169]:39721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PjyIn-0006bS-8O for emacs-devel@gnu.org; Mon, 31 Jan 2011 13:16:37 -0500 Original-Received: by iyj17 with SMTP id 17so6125023iyj.0 for ; Mon, 31 Jan 2011 10:16:36 -0800 (PST) Original-Received: by 10.231.207.84 with SMTP id fx20mr6939036ibb.62.1296497795738; Mon, 31 Jan 2011 10:16:35 -0800 (PST) Original-Received: by 10.231.39.130 with HTTP; Mon, 31 Jan 2011 10:16:14 -0800 (PST) X-Originating-IP: [99.116.250.80] In-Reply-To: <87r5i26s01.fsf@gmail.com> X-Google-Sender-Auth: NpXM7vXV08KMMrOsbuSyt7cyNrU X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.210.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135327 Archived-At: Looks good to me. On Fri, Aug 13, 2010 at 3:57 PM, Antoine Levitt wrote: > When a new ERC buffer is created (for instance, a query) while erc-track > displays information in the mode line, the information is removed. I > tracked the bug down to an initialisation of > erc-modified-channels-object each time erc-track-mode is activated (ie, > each time an ERC buffer is created). This is useless because the > variable is initialised at load time with (defvar). > > This patch simply removes the extra initialisation. I tested it, it > works for me and I don't see any potential bugs the removal might cause. > > Antoine Levitt > > =3D=3D=3D modified file 'lisp/erc/erc-track.el' > --- lisp/erc/erc-track.el =C2=A0 =C2=A0 =C2=A0 2010-01-13 08:35:10 +0000 > +++ lisp/erc/erc-track.el =C2=A0 =C2=A0 =C2=A0 2010-08-13 22:47:20 +0000 > @@ -649,7 +649,6 @@ > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (add-hook 'erc-send-completed-hook 'er= c-user-is-active) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (add-hook 'erc-server-001-functions 'e= rc-user-is-active)) > =C2=A0 =C2=A0 =C2=A0 =C2=A0(erc-track-add-to-mode-line erc-track-position= -in-mode-line) > - =C2=A0 =C2=A0 =C2=A0 (setq erc-modified-channels-object (erc-modified-c= hannels-object nil)) > =C2=A0 =C2=A0 =C2=A0 =C2=A0(erc-update-mode-line) > =C2=A0 =C2=A0 =C2=A0 =C2=A0(if (featurep 'xemacs) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (defadvice switch-to-buffer (after erc= -update (&rest args) activate) > > > --=20 Michael Olson=C2=A0 |=C2=A0 http://mwolson.org/