From: John Haman <mail@johnhaman.org>
To: Eshel Yaron <me@eshelyaron.com>
Cc: help-gnu-emacs@gnu.org
Subject: Re: Package critique: modeline for air quality information
Date: Fri, 01 Sep 2023 06:49:49 -0400 [thread overview]
Message-ID: <m1bkemkw1e.fsf@johnhaman.org> (raw)
In-Reply-To: <m1ttsexmgc.fsf@eshelyaron.com> (Eshel Yaron's message of "Fri, 01 Sep 2023 11:38:27 +0200")
Thank you for the fast and thorough response!
This definitely makes the package better. I applied the patch.
I had some 404 issue with the new version of `air-quality--make-api-call', so I reverted back to the old one that just uses a simple string concatenation. Is that OK? Or is there some specific advantage to using `url-parse-make-urlobj' ?
https://github.com/jthaman/air-quality
You might check to see if I implemented the variable checking in a correct way in the definition of `air-quality-mode'.
-John
--
Dr. John Haman
Maryland, USA
next prev parent reply other threads:[~2023-09-01 10:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 1:58 Package critique: modeline for air quality information John Haman
2023-09-01 9:38 ` Eshel Yaron
2023-09-01 10:49 ` John Haman [this message]
2023-09-01 11:57 ` Eshel Yaron
2023-09-01 13:46 ` John Haman
2023-09-01 15:12 ` tpeplt
2023-09-02 21:24 ` Emanuel Berg
2023-09-03 16:42 ` John Haman
2023-09-04 1:15 ` Emanuel Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1bkemkw1e.fsf@johnhaman.org \
--to=mail@johnhaman.org \
--cc=help-gnu-emacs@gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).