unofficial mirror of help-gnu-emacs@gnu.org
 help / color / mirror / Atom feed
From: Emanuel Berg <incal@dataswamp.org>
To: help-gnu-emacs@gnu.org
Subject: Re: Package critique: modeline for air quality information
Date: Sat, 02 Sep 2023 23:24:08 +0200	[thread overview]
Message-ID: <87h6ocp8uf.fsf@dataswamp.org> (raw)
In-Reply-To: m1jztaejth.fsf@johnhaman.org

John Haman wrote:

> I wrote a package that adds local air quality statistics to
> the mode-line. Here it is:
>
> https://github.com/jthaman/air-quality/blob/main/air-quality.el
>
> If you are so inclined, I'd like some thoughts on the code.
> It's short, but I'm trying to get better at Emacs Lisp (at
> least this week, while I'm on vacation...)

Can you yank the source here as well or provide a URL to it,
that works without JS?

But in general, if you byte-compile the source, then
native-compile it, and do (checkdoc-current-buffer t) and
remove all the warnings, then the Elisp should be good enough
and you will improve in the process.

-- 
underground experts united
https://dataswamp.org/~incal




  parent reply	other threads:[~2023-09-02 21:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-01  1:58 Package critique: modeline for air quality information John Haman
2023-09-01  9:38 ` Eshel Yaron
2023-09-01 10:49   ` John Haman
2023-09-01 11:57     ` Eshel Yaron
2023-09-01 13:46       ` John Haman
2023-09-01 15:12 ` tpeplt
2023-09-02 21:24 ` Emanuel Berg [this message]
2023-09-03 16:42   ` John Haman
2023-09-04  1:15     ` Emanuel Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6ocp8uf.fsf@dataswamp.org \
    --to=incal@dataswamp.org \
    --cc=help-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).