From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: John Haman Newsgroups: gmane.emacs.help Subject: Re: Package critique: modeline for air quality information Date: Fri, 01 Sep 2023 06:49:49 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39600"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: help-gnu-emacs@gnu.org To: Eshel Yaron Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 01 12:50:50 2023 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qc1jl-000A23-DU for geh-help-gnu-emacs@m.gmane-mx.org; Fri, 01 Sep 2023 12:50:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qc1j2-0005Qm-M8; Fri, 01 Sep 2023 06:50:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qc1j0-0005QF-F4 for help-gnu-emacs@gnu.org; Fri, 01 Sep 2023 06:50:02 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qc1iv-00021H-BC for help-gnu-emacs@gnu.org; Fri, 01 Sep 2023 06:50:02 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 113F75C018E; Fri, 1 Sep 2023 06:49:54 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 01 Sep 2023 06:49:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=johnhaman.org; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1693565394; x= 1693651794; bh=1kYPL63YeCBOL568K3rnTs+afj2teQfNyH7qwnq8x7M=; b=Y R+4yLjSujW0kjBupFIsI16hGadcGXjEh8l5QswiYFIxtB1psAEnhWFe80kwoMvpX HxRunayGpXa/ZvFQFFfJsSN5EvjvzZAbCDsHeV6rUHzOQ7XQIhEhj8UStph+TrG/ 6wjK60gSg/ZDt6wyrHChYr8R8WScpv3KpuNdi8Q8mktuPS/YlTSGRiEHNKCnMv76 nJxH7i/cz+rSeM97POoYmVNXQn9yGwnTXXWyeGuZyACeMfm+QbRgPiBOn914UI/8 5Seheq1R/K8vVfPJwbavmLY1Amn9z7/WKwa30tcyHyKE0irC+w0jrsyJW94whWCx DNVIInrLYMvBGytAPveYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1693565394; x=1693651794; bh=1kYPL63YeCBOL 568K3rnTs+afj2teQfNyH7qwnq8x7M=; b=io6nMlJUeXQ9Scs7jMQIyM8qb8J4z lVVfdp7sZeK+e9ucwQIN2QL4rlICUlPIOJmr5bbjs4MlnX3e0BastJWdoAE/y+Rq 7wLlxEWumoxoRSkY0oBBcf8L/wfBpHZ3oFETeLn4uWdUqcYitSEwkuh/gyRKTPf4 sZ2V27Hku94GiILCwrshgqVUPA2ZBRIgMolBe9C27n5xoBgkCpiSljgOKzWDJKgm iTkWg7Z2YOAGjjw1nIiRuUSuj8Tie2tCkeIGq2q5dUoGeih/k81+vqVmjj/gpU/U Nko3F299lzKXutGo6sqMpA+TOrDY7wMeeFfRMt7l60cKi2xKE2lan4dCg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudegvddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufgjfhffkfgfgggtsehttd ertddtredtnecuhfhrohhmpeflohhhnhcujfgrmhgrnhcuoehmrghilhesjhhohhhnhhgr mhgrnhdrohhrgheqnecuggftrfgrthhtvghrnhepfedtfffhffehuedvgffgieevvdegff elheehveetudekgfeigefgfeefudduuedvnecuffhomhgrihhnpehgihhthhhusgdrtgho mhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg hilhesjhhohhhnhhgrmhgrnhdrohhrgh X-ME-Proxy: Feedback-ID: idfe144c2:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Sep 2023 06:49:52 -0400 (EDT) In-Reply-To: (Eshel Yaron's message of "Fri, 01 Sep 2023 11:38:27 +0200") Received-SPF: pass client-ip=66.111.4.25; envelope-from=mail@johnhaman.org; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.help:145049 Archived-At: Thank you for the fast and thorough response! This definitely makes the package better. I applied the patch. I had some 404 issue with the new version of `air-quality--make-api-call', so I reverted back to the old one that just uses a simple string concatenation. Is that OK? Or is there some specific advantage to using `url-parse-make-urlobj' ? https://github.com/jthaman/air-quality You might check to see if I implemented the variable checking in a correct way in the definition of `air-quality-mode'. -John -- Dr. John Haman Maryland, USA