Setting numecir values according to symbol

Setting numecir values according to symbol

[Heime]

Am currently implementing a system that sets the minibuffer completion framework for emacs.
I set the numeric value of "mbcomplt" according the value of a variable "armg" which is a symbol.

Perhaps I can implement the setting of "mbcomplt" in a much more straightforward manner than
using the following implementation.

  (defvar mbcomplt 0)

  (cond
   ((eq armg 'auto) (setq mbcomplt 0)
   ((eq armg 'icomplt-horz) (setq mbcomplt 1)
   ((eq armg 'icomplt-vert) (setq mbcomplt 2)
   ((eq armg 'ivy) (setq mbcomplt 3)
   ((eq armg 'vertico) (setq mbcomplt 4)
   ((eq armg 'helm) (setq mbcomplt 5)))

Re: Setting numecir values according to symbol

[Stefan Monnier via Users list for the GNU Emacs text editor]

Heime [2022-10-30 04:31:34] wrote:

> Am currently implementing a system that sets the minibuffer completion
> framework for emacs.  I set the numeric value of "mbcomplt" according
> the value of a variable "armg" which is a symbol.
>
> Perhaps I can implement the setting of "mbcomplt" in a much more
> straightforward manner than using the following implementation.
>
>   (defvar mbcomplt 0)
>
>   (cond
>    ((eq armg 'auto) (setq mbcomplt 0)
>    ((eq armg 'icomplt-horz) (setq mbcomplt 1)
>    ((eq armg 'icomplt-vert) (setq mbcomplt 2)
>    ((eq armg 'ivy) (setq mbcomplt 3)
>    ((eq armg 'vertico) (setq mbcomplt 4)
>    ((eq armg 'helm) (setq mbcomplt 5)))

Without giving more info about how you're using those two vars, it's hard
to tell, but my crystal ball tells that you're probably better off
getting rid of `mbcomplt` and using `armg` instead.


        Stefan

Re: Setting numecir values according to symbol

[Emanuel Berg]

Stefan Monnier via Users list for the GNU Emacs text editor wrote:

>>   (defvar mbcomplt 0)
>>
>>   (cond
>>    ((eq armg 'auto) (setq mbcomplt 0)
>>    ((eq armg 'icomplt-horz) (setq mbcomplt 1)
>>    ((eq armg 'icomplt-vert) (setq mbcomplt 2)
>>    ((eq armg 'ivy) (setq mbcomplt 3)
>>    ((eq armg 'vertico) (setq mbcomplt 4)
>>    ((eq armg 'helm) (setq mbcomplt 5)))
>
> Without giving more info about how you're using those two
> vars, it's hard to tell, but my crystal ball tells that
> you're probably better off getting rid of `mbcomplt` and
> using `armg` instead.

Because one variable shouldn't be functionally dependent on
another ...

-- 
underground experts united
https://dataswamp.org/~incal

Re: Setting numecir values according to symbol

[Heime]

------- Original Message -------
On Sunday, October 30th, 2022 at 1:01 PM, Emanuel Berg <incal@dataswamp.org> wrote:


> Stefan Monnier via Users list for the GNU Emacs text editor wrote:
> 
> > > (defvar mbcomplt 0)
> > > 
> > > (cond
> > > ((eq armg 'auto) (setq mbcomplt 0)
> > > ((eq armg 'icomplt-horz) (setq mbcomplt 1)
> > > ((eq armg 'icomplt-vert) (setq mbcomplt 2)
> > > ((eq armg 'ivy) (setq mbcomplt 3)
> > > ((eq armg 'vertico) (setq mbcomplt 4)
> > > ((eq armg 'helm) (setq mbcomplt 5)))

I did simplify this with the following "cl-case".  Am interested in seeing
how a can implement the equivalent using "pcase".

(setq mbcomplt
  (cl-case armg
    ('auto 0)
    ('icomplt-horz 1)
    ('icomplt-vert 2)
    ('ivy 3)
    ('vertico 4)
    ('helm 5)))

Would this be all, as below?

(setq mbcomplt
  (pcase armg
    ('auto 0)
    ('icomplt-horz 1)
    ('icomplt-vert 2)
    ('ivy 3)
    ('vertico 4)
    ('helm 5)))

Re: Setting numecir values according to symbol

[Emanuel Berg]

Heime wrote:

> I did simplify this with the following "cl-case".
> Am interested in seeing how a can implement the equivalent
> using "pcase".
>
> (setq mbcomplt
>   (cl-case armg
>     ('auto 0)
>     ('icomplt-horz 1)
>     ('icomplt-vert 2)
>     ('ivy 3)
>     ('vertico 4)
>     ('helm 5)))

Again, that's not a good idea to do, to just set one variable
to something depending on some other, it's error-prone and it
doesn't bring anything, really, the information is already
there and does not increase from that (what you just did).

Also, what you have done looks like an enumeration from C,
actually I don't know if that is any better since its
a variation of what I just said one shouldn't do, but if it's
just a matter of doing that you can do

(setq mbcomplt-armg
  (list 'auto 'icomplt-horz 'icomplt-vert 'ivy 'vertico 'helm) )

(cl-position 'auto         mbcomplt-armg) ; 0
(cl-position 'icomplt-horz mbcomplt-armg) ; 1
                                          ; etc

Well, it's a little bit better since the information is
"built-in", but the so-called position should still not be
used unless the list has some order one has decided to uphold
(and has some meaning).

> Would this be all, as below?
>
> (setq mbcomplt
>   (pcase armg
>     ('auto 0)
>     ('icomplt-horz 1)
>     ('icomplt-vert 2)
>     ('ivy 3)
>     ('vertico 4)
>     ('helm 5)))

Yes, but I don't see any reason to use `pcase' here, even less
than `cl-case' ...

-- 
underground experts united
https://dataswamp.org/~incal