unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Glenn Morris <rgm@gnu.org>
To: Bozhidar Batsov <bozhidar@batsov.com>
Cc: Sebastian Wiesner <lunaryorn@gmail.com>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: Mark custom function for interactive use only
Date: Mon, 25 Nov 2013 22:18:52 -0500	[thread overview]
Message-ID: <yczjorq28z.fsf@fencepost.gnu.org> (raw)
In-Reply-To: etPan.52938639.515f007c.16016@Bozhidars-MacBook-Pro.local


When installing changes by others, please think about the copyright
assignment aspect. The rule is, we can accept no more than 10-15 lines
total (cumulative over all changes) from any one person without an
assignment. Changes that fall under that rule should be marked "(tiny
change") in the ChangeLog.

I'd say this one qualifies as a tiny change (although it's more than 15
lines, much of it is mechanical). We would probably need a copyright
assignment to accept any more from this author, though.

Also, please try and use --author when you commit someone else's changes
(Emacs can do this for you).


BTW, I think it would be nicer if I could write:

  (put 'comint-run 'interactive-only 'make-comint)

instead of:

  (put 'comint-run 'interactive-only "Use `make-comint' instead")

Also, the installed change is inconsistent as to whether "Use `foo'
instead" should end in a period (I guess it should).

Also also, maybe "; use `foo' instead." with no preceding newline would
look better most of the time?



  parent reply	other threads:[~2013-11-26  3:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-24 15:29 Mark custom function for interactive use only Sebastian Wiesner
2013-11-24 18:22 ` Stefan Monnier
2013-11-24 19:52   ` Sebastian Wiesner
2013-11-25  3:10     ` Stefan Monnier
2013-11-25 10:05       ` Sebastian Wiesner
2013-11-25 10:41       ` Sebastian Wiesner
2013-11-25 10:42         ` Sebastian Wiesner
2013-11-25 10:54           ` Bozhidar Batsov
2013-11-25 11:34             ` Sebastian Wiesner
2013-11-25 13:11               ` Bozhidar Batsov
2013-11-25 11:33           ` Sebastian Wiesner
2013-11-25 14:58             ` Stefan Monnier
2013-11-25 15:42               ` Sebastian Wiesner
2013-11-25 17:17                 ` Bozhidar Batsov
2013-11-25 17:48                   ` Sebastian Wiesner
2013-11-25 19:36                     ` Bozhidar Batsov
2013-11-26  3:18                   ` Glenn Morris [this message]
2013-11-26  6:46                     ` Bozhidar Batsov
2013-11-26  9:06                       ` Andreas Schwab
2013-11-26  9:24                         ` Bozhidar Batsov
     [not found]                       ` <CALf2awQ3TJcNq2GiXObEgPBm+JOqrveNrEaTak0E0ws+jrh3dw@mail.gmail.com>
2013-11-26  9:55                         ` Bozhidar Batsov
2013-11-26 19:46                           ` Glenn Morris
2013-11-26 21:16                     ` Sebastian Wiesner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yczjorq28z.fsf@fencepost.gnu.org \
    --to=rgm@gnu.org \
    --cc=bozhidar@batsov.com \
    --cc=emacs-devel@gnu.org \
    --cc=lunaryorn@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).