From: Bozhidar Batsov <bozhidar@batsov.com>
To: Sebastian Wiesner <lunaryorn@gmail.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Mark custom function for interactive use only
Date: Tue, 26 Nov 2013 11:55:20 +0200 [thread overview]
Message-ID: <etPan.52947008.216231b.16016@Bozhidars-MacBook-Pro.local> (raw)
In-Reply-To: <CALf2awQ3TJcNq2GiXObEgPBm+JOqrveNrEaTak0E0ws+jrh3dw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3198 bytes --]
On November 26, 2013 at 11:40:49 AM, Sebastian Wiesner (lunaryorn@gmail.com) wrote:
Am 26.11.2013 07:46 schrieb "Bozhidar Batsov" <bozhidar@batsov.com>:
>
> On 26 November 2013 05:18, Glenn Morris <rgm@gnu.org> wrote:
>>
>>
>> When installing changes by others, please think about the copyright
>> assignment aspect. The rule is, we can accept no more than 10-15 lines
>> total (cumulative over all changes) from any one person without an
>> assignment. Changes that fall under that rule should be marked "(tiny
>> change") in the ChangeLog.
>
>
> I'm aware of this. I also know Sebastian from working on other projects and he recently mentioned that he has signed the FSF contributor agreement, that's why I didn't brought up the matter.
That's a misunderstanding. I have not signed an agreement, and certainly did not say so.
Hmm, I was fooled by this tweet of yours "Doesn't cover the hardest thing, though: Sitting at home and waiting for the FSF's CA papers :)”, because afterwards you asked me how long did it take for my paperwork to go through and I assumed you were waiting for your paperwork to go through. This was last month so now I simply thought you were done with the waiting and were starting to hack on Emacs. Obviously I was wrong.
I thought that this change would qualify as tiny, and thus didn't mention it.
Yeah. Glenn already mentioned he considers the change tiny.
It would be unfortunate if I had to go through the legal procedure for this little patch. Had I know this, I would not have written it.
I should double check such details in the future. Since I work on so many projects on GitHub I’m not used to thinking about such legal details. Btw, where’s the list of people who have signed the agreement?
>
>>
>>
>> I'd say this one qualifies as a tiny change (although it's more than 15
>> lines, much of it is mechanical). We would probably need a copyright
>> assignment to accept any more from this author, though.
>>
>>
>> Also, please try and use --author when you commit someone else's changes
>> (Emacs can do this for you).
>
>
> Actually I committed this with Sebastian as the author, but I did so using a git-bzr bridge and although in git I see him as the committer in bzr it's me. I guess I should apply patches from other people using bzr directly since obviously git-bzr doesn't handle this aspect of the workflow correctly.
>
>>
>>
>>
>> BTW, I think it would be nicer if I could write:
>>
>> (put 'comint-run 'interactive-only 'make-comint)
>>
>> instead of:
>>
>> (put 'comint-run 'interactive-only "Use `make-comint' instead")
>
>
> I've been thinking the same thing, but I noticed that some texts were more complex than the common pattern, which is probably the motivation for the use of the string argument.
> I'll think a bit more how this could be improved further.
>
>>
>>
>> Also, the installed change is inconsistent as to whether "Use `foo'
>> instead" should end in a period (I guess it should).
>>
>> Also also, maybe "; use `foo' instead." with no preceding newline would
>> look better most of the time?
>
>
> I'll have a look at this.
[-- Attachment #2: Type: text/html, Size: 6044 bytes --]
next prev parent reply other threads:[~2013-11-26 9:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 15:29 Mark custom function for interactive use only Sebastian Wiesner
2013-11-24 18:22 ` Stefan Monnier
2013-11-24 19:52 ` Sebastian Wiesner
2013-11-25 3:10 ` Stefan Monnier
2013-11-25 10:05 ` Sebastian Wiesner
2013-11-25 10:41 ` Sebastian Wiesner
2013-11-25 10:42 ` Sebastian Wiesner
2013-11-25 10:54 ` Bozhidar Batsov
2013-11-25 11:34 ` Sebastian Wiesner
2013-11-25 13:11 ` Bozhidar Batsov
2013-11-25 11:33 ` Sebastian Wiesner
2013-11-25 14:58 ` Stefan Monnier
2013-11-25 15:42 ` Sebastian Wiesner
2013-11-25 17:17 ` Bozhidar Batsov
2013-11-25 17:48 ` Sebastian Wiesner
2013-11-25 19:36 ` Bozhidar Batsov
2013-11-26 3:18 ` Glenn Morris
2013-11-26 6:46 ` Bozhidar Batsov
2013-11-26 9:06 ` Andreas Schwab
2013-11-26 9:24 ` Bozhidar Batsov
[not found] ` <CALf2awQ3TJcNq2GiXObEgPBm+JOqrveNrEaTak0E0ws+jrh3dw@mail.gmail.com>
2013-11-26 9:55 ` Bozhidar Batsov [this message]
2013-11-26 19:46 ` Glenn Morris
2013-11-26 21:16 ` Sebastian Wiesner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=etPan.52947008.216231b.16016@Bozhidars-MacBook-Pro.local \
--to=bozhidar@batsov.com \
--cc=emacs-devel@gnu.org \
--cc=lunaryorn@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).