From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: Mark custom function for interactive use only Date: Mon, 25 Nov 2013 22:18:52 -0500 Message-ID: References: <3F18D207-3DA2-4003-B995-A8867E8F0140@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1385435933 19466 80.91.229.3 (26 Nov 2013 03:18:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Nov 2013 03:18:53 +0000 (UTC) Cc: Sebastian Wiesner , Stefan Monnier , emacs-devel@gnu.org To: Bozhidar Batsov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 26 04:18:59 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vl9Aw-0006ZO-U0 for ged-emacs-devel@m.gmane.org; Tue, 26 Nov 2013 04:18:59 +0100 Original-Received: from localhost ([::1]:56131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl9Aw-0004sV-9I for ged-emacs-devel@m.gmane.org; Mon, 25 Nov 2013 22:18:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl9As-0004ov-FH for emacs-devel@gnu.org; Mon, 25 Nov 2013 22:18:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vl9Ar-0003cN-BO for emacs-devel@gnu.org; Mon, 25 Nov 2013 22:18:54 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vl9Ar-0003cJ-7k for emacs-devel@gnu.org; Mon, 25 Nov 2013 22:18:53 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Vl9Aq-000237-Jf; Mon, 25 Nov 2013 22:18:52 -0500 X-Spook: BCCI INS Ft. Bragg NWO INSCOM David John Oates Craig X-Ran: Y]?z](Fgr1L|o^-c}#nFsX=Mf@!EbgaUm|U+pd$>o}{`HNsi\?*\.)Sz&5>`=n5q@$[E#x X-Hue: white X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165735 Archived-At: When installing changes by others, please think about the copyright assignment aspect. The rule is, we can accept no more than 10-15 lines total (cumulative over all changes) from any one person without an assignment. Changes that fall under that rule should be marked "(tiny change") in the ChangeLog. I'd say this one qualifies as a tiny change (although it's more than 15 lines, much of it is mechanical). We would probably need a copyright assignment to accept any more from this author, though. Also, please try and use --author when you commit someone else's changes (Emacs can do this for you). BTW, I think it would be nicer if I could write: (put 'comint-run 'interactive-only 'make-comint) instead of: (put 'comint-run 'interactive-only "Use `make-comint' instead") Also, the installed change is inconsistent as to whether "Use `foo' instead" should end in a period (I guess it should). Also also, maybe "; use `foo' instead." with no preceding newline would look better most of the time?