* Re: feature/native-comp 2ac6194 1/2: * Add new customize `comp-async-env-modifier-form' (Bug#40838)
[not found] ` <20200518201403.5855320BC2@vcs0.savannah.gnu.org>
@ 2020-05-18 21:23 ` Stefan Monnier
2020-05-18 22:03 ` Andrea Corallo
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2020-05-18 21:23 UTC (permalink / raw)
To: emacs-devel; +Cc: Andrea Corallo
> * lisp/emacs-lisp/comp.el (comp-async-env-modifier-form): New customize.
Global variables holding *forms* imply the use of `eval` one way or
another, so kitten will die, and karma goes down.
So if you replace those forms with *functions*, you will save the
corresponding number of kitten and your karma will go up.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: feature/native-comp 2ac6194 1/2: * Add new customize `comp-async-env-modifier-form' (Bug#40838)
2020-05-18 21:23 ` feature/native-comp 2ac6194 1/2: * Add new customize `comp-async-env-modifier-form' (Bug#40838) Stefan Monnier
@ 2020-05-18 22:03 ` Andrea Corallo
2020-05-19 3:27 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Andrea Corallo @ 2020-05-18 22:03 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> * lisp/emacs-lisp/comp.el (comp-async-env-modifier-form): New customize.
>
> Global variables holding *forms* imply the use of `eval` one way or
> another, so kitten will die, and karma goes down.
>
> So if you replace those forms with *functions*, you will save the
> corresponding number of kitten and your karma will go up.
>
>
> Stefan
Hi Stefan,
nothing against kittens but I'm not really sure we can put a function
there. Have you took a look on how it's used?
Happy to save a kitten if we can!
Andrea
--
akrl@sdf.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: feature/native-comp 2ac6194 1/2: * Add new customize `comp-async-env-modifier-form' (Bug#40838)
2020-05-18 22:03 ` Andrea Corallo
@ 2020-05-19 3:27 ` Stefan Monnier
2020-05-19 7:33 ` Andrea Corallo
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2020-05-19 3:27 UTC (permalink / raw)
To: Andrea Corallo; +Cc: emacs-devel
> nothing against kittens but I'm not really sure we can put a function
> there. Have you took a look on how it's used?
Briefly, yes, and I didn't see a problem with inserting a (funcall <foo>)
in place of inserting the form. What am I missing?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: feature/native-comp 2ac6194 1/2: * Add new customize `comp-async-env-modifier-form' (Bug#40838)
2020-05-19 3:27 ` Stefan Monnier
@ 2020-05-19 7:33 ` Andrea Corallo
0 siblings, 0 replies; 4+ messages in thread
From: Andrea Corallo @ 2020-05-19 7:33 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> nothing against kittens but I'm not really sure we can put a function
>> there. Have you took a look on how it's used?
>
> Briefly, yes, and I didn't see a problem with inserting a (funcall <foo>)
> in place of inserting the form. What am I missing?
The case discussed in the PR is when some dynamically generated code (by
in this case straight.el) must me passed to the async workers to modify
the compiler environment.
`comp-async-env-modifier-form' is used with others to form the command
line that is the mechanism we use to setup and start the async workers.
`comp-async-env-modifier-form' must be then prin1-able and does not
necessarly refer to any function defined on file.
In case there's a more elegant way let's go for it.
Andrea
--
akrl@sdf.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-19 7:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200518201401.22247.78014@vcs0.savannah.gnu.org>
[not found] ` <20200518201403.5855320BC2@vcs0.savannah.gnu.org>
2020-05-18 21:23 ` feature/native-comp 2ac6194 1/2: * Add new customize `comp-async-env-modifier-form' (Bug#40838) Stefan Monnier
2020-05-18 22:03 ` Andrea Corallo
2020-05-19 3:27 ` Stefan Monnier
2020-05-19 7:33 ` Andrea Corallo
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).