From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: feature/native-comp 2ac6194 1/2: * Add new customize `comp-async-env-modifier-form' (Bug#40838) Date: Tue, 19 May 2020 07:33:30 +0000 Message-ID: References: <20200518201401.22247.78014@vcs0.savannah.gnu.org> <20200518201403.5855320BC2@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="44158"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 19 09:34:41 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jawls-000BLH-Aj for ged-emacs-devel@m.gmane-mx.org; Tue, 19 May 2020 09:34:40 +0200 Original-Received: from localhost ([::1]:48574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jawlr-00088h-BY for ged-emacs-devel@m.gmane-mx.org; Tue, 19 May 2020 03:34:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jawkq-000782-SG for emacs-devel@gnu.org; Tue, 19 May 2020 03:33:36 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:65194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jawkp-0002hK-4l for emacs-devel@gnu.org; Tue, 19 May 2020 03:33:36 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 04J7XVIb027969 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 19 May 2020 07:33:31 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 04J7XU6p025431; Tue, 19 May 2020 07:33:30 GMT In-Reply-To: (Stefan Monnier's message of "Mon, 18 May 2020 23:27:42 -0400") Received-SPF: pass client-ip=205.166.94.20; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/19 03:33:31 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250886 Archived-At: Stefan Monnier writes: >> nothing against kittens but I'm not really sure we can put a function >> there. Have you took a look on how it's used? > > Briefly, yes, and I didn't see a problem with inserting a (funcall ) > in place of inserting the form. What am I missing? The case discussed in the PR is when some dynamically generated code (by in this case straight.el) must me passed to the async workers to modify the compiler environment. `comp-async-env-modifier-form' is used with others to form the command line that is the mechanism we use to setup and start the async workers. `comp-async-env-modifier-form' must be then prin1-able and does not necessarly refer to any function defined on file. In case there's a more elegant way let's go for it. Andrea -- akrl@sdf.org